Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download binaries for Windows #6

Open
plicease opened this issue Sep 25, 2022 · 2 comments
Open

Download binaries for Windows #6

plicease opened this issue Sep 25, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@plicease
Copy link
Member

Share build seems to fail on Windows (#5). The InfoZip project seems to be pretty dormant. MSYS2 has patches to build unzip, but they are for the msys environment not the mingw environment that Strawberry uses. We should download binaries. There is a 64 bit Intel binary provided by MSYS2 here: that would probably work. Uncertain if there is a 32bit binary as well.

@plicease plicease added the enhancement New feature or request label Sep 25, 2022
@plicease
Copy link
Member Author

32bit Strawberry seems to have fewer errors, just this one:

win32/../unzpriv.h:1844:16: error: expected identifier or '(' before numeric constant
 #define CR     13        /* '\r' on ASCII machines; must be 13 due to EBCDIC */
                ^~
In file included from win32/../unzpriv.h:586,
                 from win32/../unzip.h:718,
                 from win32/win32.c:57:

so if we could patch that for 32bit Windows and get the 64 bit binary that might solve it.

@plicease
Copy link
Member Author

#7 fixes Windows 32 bit share build. So we can ignore that and just download binary for Windows 64 bit. We can support AMR64 when/if somebody complains :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant