Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain text can force IRC to crash #21

Open
emwjacobson opened this issue Jun 28, 2020 · 0 comments
Open

Certain text can force IRC to crash #21

emwjacobson opened this issue Jun 28, 2020 · 0 comments

Comments

@emwjacobson
Copy link

emwjacobson commented Jun 28, 2020

if text.find('Login authentication failed') > 0:
logging.fatal('IRC authentication error: ' + text or '')
return

If a user types "Login authentication failed" in chat, regardless of if the IRC connection has actually failed, it will trigger the fatal logging and return from the active loop.

A suggested fix could be to check to make sure it was not sent via a PRIVMSG

if text.find('Login authentication failed') > 0 and text.find('PRIVMSG') == -1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant