Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasional crashes on uninject #6

Open
PieKing1215 opened this issue Jan 25, 2022 · 2 comments
Open

Occasional crashes on uninject #6

PieKing1215 opened this issue Jan 25, 2022 · 2 comments
Labels
crash It crashed

Comments

@PieKing1215
Copy link
Owner

Needs testing/debugging to figure out what triggers it.
I think this might be a recent problem (like within a day), but not 100% sure.
Sometimes it prints segfault, sometimes not.
@PieKing1215 PieKing1215 added the crash It crashed label Jan 25, 2022
@PieKing1215 PieKing1215 moved this to TODO in ptcMod Jan 25, 2022
PieKing1215 added a commit that referenced this issue Jan 25, 2022
@PieKing1215
Remove extra copied cleanup code copied from FPSUnlock to Playhead
c4ba492 
Maybe related to gh-6?
@PieKing1215
Copy link
Owner Author

PieKing1215 commented Jan 26, 2022 •
edited
Loading

Note to self: maybe the problem is unapplying the Patches from the non-main thread.
If so, a solution might be moving the Patch cleanup elsewhere, maybe into runtime::hook_ex

@PieKing1215
Copy link
Owner Author

Note to self 2.0: might happen primarily while playing with scroll hook enabled, possible solution would be stopping the song before cleaning up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash It crashed
Projects
ptcMod
Status: TODO
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PieKing1215