From cade02405c4678229c2f061770f80e7898da2791 Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Sun, 8 Dec 2024 16:58:46 -0800
Subject: [PATCH] clang-tidy: use std::min/max

Found with readability-use-std-min-max

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 pdns/dnspacket.cc    |  4 ++--
 pdns/dnsparser.cc    |  5 ++---
 pdns/lua-record.cc   | 20 ++++++++------------
 pdns/sillyrecords.cc |  4 ++--
 4 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/pdns/dnspacket.cc b/pdns/dnspacket.cc
index 8588f2c21a151..2afde53a35964 100644
--- a/pdns/dnspacket.cc
+++ b/pdns/dnspacket.cc
@@ -23,6 +23,7 @@
 #include "config.h"
 #endif
 #include "utility.hh"
+#include <algorithm>
 #include <cstdio>
 #include <cstdlib>
 #include <sys/types.h>
@@ -245,8 +246,7 @@ unsigned int DNSPacket::getMinTTL()
 {
   unsigned int minttl = UINT_MAX;
   for(const DNSZoneRecord& rr :  d_rrs) {
-  if (rr.dr.d_ttl < minttl)
-      minttl = rr.dr.d_ttl;
+    minttl = std::min(minttl, rr.dr.d_ttl);
   }
 
   return minttl;
diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
index e1f81a14d3e86..a97d2399e2e49 100644
--- a/pdns/dnsparser.cc
+++ b/pdns/dnsparser.cc
@@ -21,6 +21,7 @@
  */
 #include "dnsparser.hh"
 #include "dnswriter.hh"
+#include <algorithm>
 #include <boost/algorithm/string.hpp>
 #include <boost/format.hpp>
 
@@ -1009,9 +1010,7 @@ uint32_t getDNSPacketMinTTL(const char* packet, size_t length, bool* seenAuthSOA
       }
 
       const uint32_t ttl = dpm.get32BitInt();
-      if (result > ttl) {
-        result = ttl;
-      }
+      result = std::min(result, ttl);
 
       dpm.skipRData();
     }
diff --git a/pdns/lua-record.cc b/pdns/lua-record.cc
index 1f2344a881b5e..c75249524e898 100644
--- a/pdns/lua-record.cc
+++ b/pdns/lua-record.cc
@@ -1,3 +1,4 @@
+#include <algorithm>
 #include <thread>
 #include <future>
 #include <boost/format.hpp>
@@ -1095,19 +1096,14 @@ static void setupLuaRecords(LuaContext& lua) // NOLINT(readability-function-cogn
    *
    * @example ifportup(443, { '1.2.3.4', '5.4.3.2' })"
    */
-  lua.writeFunction("ifportup", [](int port, const boost::variant<iplist_t, ipunitlist_t>& ips, const boost::optional<std::unordered_map<string,string>> options) {
-      if (port < 0) {
-        port = 0;
-      }
-      if (port > std::numeric_limits<uint16_t>::max()) {
-        port = std::numeric_limits<uint16_t>::max();
-      }
+  lua.writeFunction("ifportup", [](int port, const boost::variant<iplist_t, ipunitlist_t>& ips, boost::optional<std::unordered_map<string, string>> options) {
+    port = std::clamp(port, 0, static_cast<int>(std::numeric_limits<uint16_t>::max()));
 
-      auto checker = [](const ComboAddress& addr, const opts_t& opts) {
-        return g_up.isUp(addr, opts);
-      };
-      return genericIfUp(ips, options, checker, port);
-    });
+    auto checker = [](const ComboAddress& addr, const opts_t& opts) {
+      return g_up.isUp(addr, opts);
+    };
+    return genericIfUp(ips, options, checker, port);
+  });
 
   lua.writeFunction("ifurlextup", [](const vector<pair<int, opts_t> >& ipurls, boost::optional<opts_t> options) {
       vector<ComboAddress> candidates;
diff --git a/pdns/sillyrecords.cc b/pdns/sillyrecords.cc
index cc04a3c29f390..a6edc189e2903 100644
--- a/pdns/sillyrecords.cc
+++ b/pdns/sillyrecords.cc
@@ -2,6 +2,7 @@
 #include "config.h"
 #endif
 
+#include <algorithm>
 #include <boost/format.hpp>
 
 #include "utility.hh"
@@ -46,8 +47,7 @@ static uint8_t precsize_aton(const char **strptr)
       break;
 
   mantissa = cmval / poweroften[exponent];
-  if (mantissa > 9)
-    mantissa = 9;
+  mantissa = std::min(mantissa, 9);
 
   retval = (mantissa << 4) | exponent;