Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no id prefix for abilities/traits #15

Open
sevu opened this issue Mar 31, 2019 · 3 comments
Open

no id prefix for abilities/traits #15

sevu opened this issue Mar 31, 2019 · 3 comments

Comments

@sevu
Copy link
Collaborator

sevu commented Mar 31, 2019

in difference to race and unit type, they do not need a prefix.

Abilites and traits are dumped by macros into the units, not called by id.
A few one use events for their implementation, which check for the id, however, these events are inserted either by the era or the unit type, and thus cause no problems either.

But the prefix has ir may have an disadvantage: The help may list the AE and EoMa version. (or may not?)

TL;DR: getting that changed in the porting script at some point

related, but different: inferno8/wesnoth-Era_of_Magic#27

@ProditorMagnus
Copy link
Owner

Distinct id might help SXC for removing them.

@sevu
Copy link
Collaborator Author

sevu commented Mar 31, 2019

In case they do, SXC wouldn't want to differentiate between the AE and EoMa version though.

@ProditorMagnus
Copy link
Owner

Specific issues can be reported, not planning focused effort on all cases. Abilities with events are more likely to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants