From cd11f1af480d6417ca31308da02470a5d54a1e95 Mon Sep 17 00:00:00 2001 From: Arpit Narechania Date: Sat, 28 Sep 2024 13:06:27 -0400 Subject: [PATCH] test-deploy with hardcoded deployed path --- README.md | 4 ++-- src/app/applications/home/component.html | 16 ++++++++-------- src/app/applications/home/component.ts | 3 +-- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 5cd336a..d158f2f 100644 --- a/README.md +++ b/README.md @@ -21,5 +21,5 @@ A Showcase of Applications Developed using ProvenanceWidgets. - GitHub Actions is setup via the `.github/workflows/build.yaml` file. Built files are pushed to `gh-pages` branch and served via GitHub Pages at [https://provenancewidgets.github.io/showcase](https://provenancewidgets.github.io/showcase). ## Development vs. Building Configurations for base-href -- Development: Because the app served from `/` while developing locally, index.html must be configured with ``. -- Build: Because the app is eventually served from `/showcase` (and not `/`), index.html must be configured with ``. In addition, we pass `--base-href /showcase/` in the `ng build` command (already configured to do this as part of `npm run build`, see package.json). \ No newline at end of file +- Development: Because the app served from `/` while developing locally, index.html must be configured with `` and `src/app/applications/home/component.ts` must have the `url` set to `${window.location.origin}/#/${route};`. +- Build: Because the app is eventually served from `/showcase` (and not `/`), index.html must be configured with `` and `src/app/applications/home/component.ts` must have the `url` set to `${window.location.origin}/showcase/#/${route};`. In addition, we pass `--base-href /showcase/` in the `ng build` command (already configured to do this as part of `npm run build`, see package.json). \ No newline at end of file diff --git a/src/app/applications/home/component.html b/src/app/applications/home/component.html index 5c133d1..805dd0a 100644 --- a/src/app/applications/home/component.html +++ b/src/app/applications/home/component.html @@ -25,7 +25,7 @@

Showcase

- +
Playground
@@ -34,7 +34,7 @@
Playground
-
+
Scented Widgets
@@ -45,7 +45,7 @@
Scented Widgets
- +
Phosphor Objects
@@ -55,7 +55,7 @@
Phosphor Objects
- +
Data Distribution
@@ -68,7 +68,7 @@
Data Distribution

- +
Vega Integration
@@ -78,7 +78,7 @@
Vega Integration
- +
Dynamic Query Widgets
@@ -88,7 +88,7 @@
Dynamic Query Widgets
- +
Widgets to Visualization one-way
@@ -98,7 +98,7 @@
Widgets to Visualization one-way
- +
Visualization to Widgets one-way
diff --git a/src/app/applications/home/component.ts b/src/app/applications/home/component.ts index f60e6fa..41170f9 100644 --- a/src/app/applications/home/component.ts +++ b/src/app/applications/home/component.ts @@ -16,8 +16,7 @@ export class HomeComponent implements OnInit { ngOnInit(): void { } navigateToRoute(route:string){ - const baseHref = this.location.normalize('/'); - const url = `${window.location.origin}${baseHref}#${route}`; + const url = `${window.location.origin}/showcase/#/${route}`; window.open(url, '_blank'); } }