Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework _generate_momenta interface #74

Closed
AntonReinhard opened this issue Jun 21, 2024 · 0 comments · Fixed by #95
Closed

Rework _generate_momenta interface #74

AntonReinhard opened this issue Jun 21, 2024 · 0 comments · Fixed by #95
Assignees
Labels
01 - Bug Something isn't working as expected; needs a fix
Milestone

Comments

@AntonReinhard
Copy link
Member

As it stands currently, the _generate_momenta interface cannot be implemented physically.

The functions will need to be:

    _generate_incoming_momenta
        proc::AbstractProcessDefinition,
        model::AbstractModelDefinition,
        phase_space_def::AbstractPhasespaceDefinition,
        in_phase_space::NTuple{N,T},
    ) where {N,T<:Real}
    _generate_outgoing_momenta
        proc::AbstractProcessDefinition,
        model::AbstractModelDefinition,
        phase_space_def::AbstractPhasespaceDefinition,
        in_phase_space::NTuple{N,T},
        out_phase_space::NTuple{N,T},
    ) where {N,T<:Real}

I.e., the outgoing momenta need both in and out phase spaces. The derived function then needs to be changed correspondingly:

function _generate_momenta(
    proc::AbstractProcessDefinition,
    model::AbstractModelDefinition,
    phase_space_def::AbstractPhasespaceDefinition,
    in_phase_space::NTuple{N,T},
    out_phase_space::NTuple{M,T},
) where {N,M,T<:Real}
    in_momenta = _generate_incoming_momenta(proc, model, phase_space_def, in_phase_space)
    out_momenta = _generate_outgoing_momenta(proc, model, phase_space_def, in_phase_space, out_phase_space)

    return in_momenta, out_momenta
end

(Opened from discussion on #68)

@AntonReinhard AntonReinhard added the 01 - Bug Something isn't working as expected; needs a fix label Jun 21, 2024
@AntonReinhard AntonReinhard self-assigned this Jul 5, 2024
@AntonReinhard AntonReinhard added this to the Release-next milestone Jul 5, 2024
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this issue Jul 11, 2024
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - Bug Something isn't working as expected; needs a fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant