We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As it stands currently, the _generate_momenta interface cannot be implemented physically.
_generate_momenta
The functions will need to be:
_generate_incoming_momenta proc::AbstractProcessDefinition, model::AbstractModelDefinition, phase_space_def::AbstractPhasespaceDefinition, in_phase_space::NTuple{N,T}, ) where {N,T<:Real} _generate_outgoing_momenta proc::AbstractProcessDefinition, model::AbstractModelDefinition, phase_space_def::AbstractPhasespaceDefinition, in_phase_space::NTuple{N,T}, out_phase_space::NTuple{N,T}, ) where {N,T<:Real}
I.e., the outgoing momenta need both in and out phase spaces. The derived function then needs to be changed correspondingly:
function _generate_momenta( proc::AbstractProcessDefinition, model::AbstractModelDefinition, phase_space_def::AbstractPhasespaceDefinition, in_phase_space::NTuple{N,T}, out_phase_space::NTuple{M,T}, ) where {N,M,T<:Real} in_momenta = _generate_incoming_momenta(proc, model, phase_space_def, in_phase_space) out_momenta = _generate_outgoing_momenta(proc, model, phase_space_def, in_phase_space, out_phase_space) return in_momenta, out_momenta end
(Opened from discussion on #68)
The text was updated successfully, but these errors were encountered:
1481a81
Fix the interface for momentum generation (QEDjl-project#95)
bc069be
Closes QEDjl-project#74
1037717
AntonReinhard
Successfully merging a pull request may close this issue.
As it stands currently, the
_generate_momenta
interface cannot be implemented physically.The functions will need to be:
I.e., the outgoing momenta need both in and out phase spaces. The derived function then needs to be changed correspondingly:
(Opened from discussion on #68)
The text was updated successfully, but these errors were encountered: