Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Report in Iframe #190

Open
gbdubs opened this issue Feb 16, 2024 · 4 comments
Open

Show Report in Iframe #190

gbdubs opened this issue Feb 16, 2024 · 4 comments
Labels
cleanup Improve code health without changing UX

Comments

@gbdubs
Copy link
Contributor

gbdubs commented Feb 16, 2024

Rather than showing the report in a new tab, Hodie would like the default to be to iFrame it (which should be simple - particularly if it's modal'ed). We can still offer within that iFrame the capability to see a full-screen version of it via a link.

@gbdubs gbdubs added feature A new capability cleanup Improve code health without changing UX and removed feature A new capability labels Feb 16, 2024
@gbdubs gbdubs added this to the MS1 - Good Demo milestone Feb 16, 2024
@hodie
Copy link

hodie commented Jul 19, 2024

@jdhoffa @MonikaFu something to keep in mind when designing the new dashboard.

@gbdubs we are in the progress of replacing that long, long, long html "report" to a more traditional dashboard so that browsing the data becomes more intuitive. Docker image would still produce the outputs. Exact specs TBD. Probably good @MonikaFu , @gbdubs , @AlexAxthelm to sync once ideas have evolved more.

@gbdubs
Copy link
Contributor Author

gbdubs commented Jul 19, 2024

@bcspragu FYI

@jdhoffa
Copy link
Member

jdhoffa commented Jul 26, 2024

Just a quick update on this at this stage I don't think the invocation or structure of this "dashboard" will be much different at all from the interactive report that is currently being integrated (in fact: I am working to spec it so that it won't be functionally different at all).

  • We will bundle the whole process in a docker image
  • The docker image will run once, with the same config file that is currently used by workflow.pacta.webnapp
  • That will run will: run pacta on the given portfolio, build all necessary assets/ json data required by the dashboard
  • Produce a static site, that can be plopped in an iFrame somewhere

@AlexAxthelm if you think I'm glossing over any details or missing something critical let me know?

(a VERY rough prototype is being served here: https://rmi-pacta.github.io/pacta-dashboard-svelte/)

@hodie
Copy link

hodie commented Jul 26, 2024

Dark mode!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improve code health without changing UX
Projects
None yet
Development

No branches or pull requests

3 participants