Deprecation notice has a confusing warning message

[jdhoffa]

In particular, calling r2dii.plot::plot_emission_intensity(data) prior to calling r2dii.plot::plot_emission_intensity() doesn't really make sense?

See reprex:

library(r2dii.plot)

plot_emission_intensity(sda)
#> Warning: The `data` argument of `plot_emission_intensity()` must be prepped already as
#> of r2dii.plot 0.4.0.
#> ℹ From the next release you will need to call
#>   `r2dii.plot::plot_emission_intensity(data)` prior to calling
#>   `r2dii.plot::plot_emission_intensity()`.
#> ℹ Alternatively custom data preparation will also become possible.
#> This warning is displayed once every 8 hours.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.

^{Created on 2024-01-23 with reprex v2.0.2}

[MonikaFu]

you're right, it should be
ℹ From the next release you will need to call
r2dii.plot::prep_emission_intensity(data) prior to calling
r2dii.plot::plot_emission_intensity()

However, I would be happy to discuss if we want to introduce this change or not. Back then with Mauro we thought it would be a more intuitive interface. Happy to re-evaluate and either introduce the change or get rid of the message (even though it is probably not the best practice to promise something and then not do it.

[jdhoffa]

If the design choice is desirable is another topic, but we should first make sure the warning message dictates what we expect it to. :-)

[MonikaFu]

Agreed. But it is still remaining question :)