Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testthat checks on Windows #556

Closed
AlexAxthelm opened this issue Feb 22, 2024 · 5 comments
Closed

Fix testthat checks on Windows #556

AlexAxthelm opened this issue Feb 22, 2024 · 5 comments

Comments

@AlexAxthelm
Copy link
Contributor

          Note: Windows checks seem to be failing due to the breaking change to `r2dii.data` that introduced the new `increasing_or_decreasing` dataset. 

I don't really understand why only the windows checks fail, since in principle the same checks should be applied to R-CMD-check/macos-latest... in any case, I believe it is unrelated to this PR.

Originally posted by @jdhoffa in #552 (comment)

@AlexAxthelm
Copy link
Contributor Author

@AlexAxthelm
Copy link
Contributor Author

@jdhoffa

It looks like the failing checks are installing v 0.3.1 of r2dii.data
https://github.com/RMI-PACTA/r2dii.plot/actions/runs/8001784071/job/21853669742?pr=552#step:5:3747

while the passing window check (latest) is installing 0.4.1 (which is expected).
https://github.com/RMI-PACTA/r2dii.plot/actions/runs/8001784071/job/21853669276?pr=552#step:5:3639

@jdhoffa
Copy link
Member

jdhoffa commented Feb 22, 2024

Hmmm, do you have any idea why that would be? I find that strange. I wonder if it has to do with the posit package manager being down?

@AlexAxthelm
Copy link
Contributor Author

Looks like. I see that you reran the action and it ran clean. https://github.com/RMI-PACTA/r2dii.plot/actions/runs/8001784071/job/21853669742?pr=552#step:5:3293

Closing this, but maybe you want to wrap those tests in a check on r2dii.data version?

@jdhoffa
Copy link
Member

jdhoffa commented Feb 22, 2024

I'm thinking the bug was because posit package manager was down, so it was trying to install from a sub-par repository mirror. Now that it is back up, things work as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants