Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license_stamper.py not resolving check_stamped.py errors #3251

Open
eddieliao opened this issue Jul 8, 2024 · 0 comments
Open

license_stamper.py not resolving check_stamped.py errors #3251

eddieliao opened this issue Jul 8, 2024 · 0 comments
Assignees

Comments

@eddieliao
Copy link
Contributor

Running tools/license_stamper.py doesn't seem to be resolving the errors returned by check_stamped.py run by CI test.

This commit 355bc3f in my draft PR here fails the licensing check with the following error message:

Error: The licenses for the following 6 file(s) either... do not match the year of commit, have a different copyright format or have not been synced from the latest weight_streaming branch:
['src/include/migraphx/float8.hpp', 'test/fp8e4m3fn.cpp', 'test/fp8e4m3fnuz.cpp', 'test/fp8e5m2.cpp', 'test/fp8e5m2fnuz.cpp', 'test/verify/test_reduce_op_large.cpp']

However, running python3 tools/check_stamped.py weight_streaming locally returns that everything is up to date. If I use the pull request ref python3 tools/check_stamped.py pull/3222/merge returns a different set of failing files:

Error: The licenses for the following 15 file(s) either... do not match the year of commit, have a different copyright format or have not been synced from the latest pull/3222/merge branch:
['dev-requirements.txt', 'src/api/api.cpp', 'src/api/include/migraphx/migraphx.h', 'src/api/migraphx.py', 'src/include/migraphx/float8.hpp', 'src/targets/cpu/fuse_ops.cpp', 'test/api/test_cpu.cpp', 'test/fp8e4m3fn.cpp', 'test/fp8e4m3fnuz.cpp', 'test/fp8e5m2.cpp', 'test/fp8e5m2fnuz.cpp', 'test/verify/test_reduce_op_large.cpp', 'tools/api/api.cpp', 'tools/api/migraphx.h', 'tools/cppcheck/migraphx.py']
There is a license_stamper script (./tools/license_stamper.py), which you can run to automatically update and add any needed license stamps

Trying to use the license stamper with python3 tools/license_stamper.py doesn't seem to work for me; it doesn't update any of the files mentioned in either of the error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants