-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osxphotos sync export/import: mismatch fingerprint (related with push-exif and my own exiftool processing?) #1738
Comments
Doing bit more testing and I believe that is the case: fingerprint gets changed! 😢 ! Either on push-exif and/or on my exiftool update of dates and GPS position! Maybe if I do a "timewarp pull-exif" would that force Photos into recalculating the fingerprint and re-align Photos info and file info? |
Anything that modifies the file (using exiftool for example) will change the actual fingerprint of the file. I believe that Photos only computes the fingerprint once at time of import. Here's what I think is happening: Library A: sync export MetaData.db The metadata is pulled from the Photos database to write MetaData.db. The modified image (from push-exif) has a fingerprint that doesn't match what is in the database and the value that gets written is the original fingerprint not the new fingerprint. Library B: manual import of pics The modified image is imported and Photos sets the fingerprint value based on the current image. Library B: sync import MetaData.db Because the fingerprint of the imported image is different than what was originally imported into Library A, the image cannot be found. I don't know what to do about this as the code is behaving as designed. I always caution against modifying the files in the Photos library for reasons like this. One option that might work is to allow user to specify a custom template for matching photos between libraries. |
Got it. Thanks. I think that's the way to go. Thanks again. |
Before submitting a bug report, please ensure you are running the most recent version of osxphotos and that the bug is reproducible on the latest version
Describe the bug
Running a:
A few pics don't get matched: 45 out of ~3500 pics. Fingerprint is different.
To Reproduce
recreate.toml (contents)
Expected behaviour
A match to be found on the pics and the sync performed.
Investigation
If I try to import ORIGINAL.jpg or EXPORTED.jpg again into LibraryB, manually, Photos warns me they are duplicated
The
debug-dump --dump photos
does show differentLooking at the code there are a few different methods to get to the fingerprint but it seems to me "photo.fingerprint" is the one being used on both Libraries.
Question Does push-exif and exiftool changing other date/times on the file influence the fingerprint calculation from LibraryA and LibraryB? I'm thinking the process I run of:
For Images: Date/time fields I set with exiftool after push-exif)
Screenshots
N/A
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: