Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all code references to Py2neo #93

Open
yunchae-kim opened this issue Oct 10, 2023 · 0 comments · Fixed by #95
Open

Remove all code references to Py2neo #93

yunchae-kim opened this issue Oct 10, 2023 · 0 comments · Fixed by #95
Assignees
@yunchae-kim
Labels
minor Easy to fix issue that can be completed in a limited amount of time, similar to "easy fix" python Pull requests that update Python code

Comments

@yunchae-kim
Copy link
Contributor

As of PR-#92, the Py2neo package has been removed from the project's dependencies. To ensure the project's codebase is up to date, it's necessary to remove all references to the Py2neo package from the code.

This includes any imports, function calls, or code sections that use Py2neo-specific functionality. Review the entire codebase and make the necessary changes to eliminate any dependencies on Py2neo.
@yunchae-kim yunchae-kim added python Pull requests that update Python code minor Easy to fix issue that can be completed in a limited amount of time, similar to "easy fix" labels Oct 10, 2023
@yunchae-kim yunchae-kim self-assigned this Oct 10, 2023
yunchae-kim added a commit that referenced this issue Oct 10, 2023
@yunchae-kim
fix: Removed Py2neo-related code
0314c7d 
[#93] Refer to GitHub issue...

This commit removed all code references to the Py2neo package, which
were previously removed from the project's dependencies. The changes
included:

- Deleted Python code that imported and referenced Py2neo.
- Commented out references to the `Graph` class in `graph/graph.py` as
it was based on Py2neo. The decision to comment out instead of deleting
was made for future reference purposes.
- Autoformatted several Python files that hadn't been previously styled
according to the project's style guide.
- Removed the Py2neo package from `environment.yml`.

The current commit successfully passed the Pytest after modification.
@yunchae-kim yunchae-kim mentioned this issue Oct 10, 2023
Merged
@yunchae-kim yunchae-kim linked a pull request Oct 10, 2023 that will close this issue
fix: Removed Py2neo-related code #95
Merged
@yunchae-kim yunchae-kim reopened this Oct 17, 2023
@yunchae-kim yunchae-kim mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunchae-kim yunchae-kim

Labels
minor Easy to fix issue that can be completed in a limited amount of time, similar to "easy fix" python Pull requests that update Python code
Projects
ComptoxAI - Database / Python tools development
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Removed Py2neo-related code RomanoLab/comptox_ai
1 participant
@yunchae-kim