Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -D_GLIBCXX_ASSERTIONS CI #3137

Closed
CohenArthur opened this issue Aug 21, 2024 · 5 comments
Closed

Add -D_GLIBCXX_ASSERTIONS CI #3137

CohenArthur opened this issue Aug 21, 2024 · 5 comments
Labels
CI

Comments

@CohenArthur
Copy link
Member

Let's fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116225 and add a CI to make sure this no longer happens. We should make use of every little safety feature the C++ std offers us lol
@CohenArthur CohenArthur added the CI label Aug 21, 2024
@badumbatish
Copy link
Contributor

i'll do it

@badumbatish
Copy link
Contributor

hi @CohenArthur this should be fixed in #3138 :)

@CohenArthur
Copy link
Member Author

@badumbatish you're right, thanks! don't hesitate to add something like "Fixes #3138" or "Closes #3138" to your PR's main message so that these issues get closed automatically when we merge the PR

@badumbatish
Copy link
Contributor

hehe sorry this was my bad ~~

@CohenArthur
Copy link
Member Author

hehe sorry this was my bad ~~

no worries it's not a problem :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@badumbatish @CohenArthur