Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsa: Eq is missing for Components, SigningKey and VerifyingKey #881

Open
dignifiedquire opened this issue Jan 6, 2025 · 3 comments
Open

dsa: Eq is missing for Components, SigningKey and VerifyingKey #881

dignifiedquire opened this issue Jan 6, 2025 · 3 comments

Comments

@dignifiedquire
Copy link
Member

I don't see any internal details that would make an impl/derive invalid
@tarcieri
Copy link
Member

tarcieri commented Jan 6, 2025

Derived Eq on SigningKey would introduce a timing sidechannel

@dignifiedquire
Copy link
Member Author

how so, if there is already PartialEq, to which it could delegate?

@tarcieri
Copy link
Member

tarcieri commented Jan 9, 2025

It doesn't currently impl PartialEq, but regardless, the derived implementation will use a data-dependent short-circuiting check, rather than one that always performs the comparison in constant-time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @dignifiedquire