Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LREngine.Context construction to be more fluid instead of simply adding more constructor variations #1495

Open
aheber opened this issue Sep 1, 2024 · 0 comments
Assignees

Comments

@aheber
Copy link
Contributor

aheber commented Sep 1, 2024

Is your feature request related to a problem? Please describe.
If we want to enhance the capabilities of LREngine it often means adding new settings. Passing in those settings means adding for properties to LREngine.Context. The current model adds another constructor param and cascades the existing constructors. This is untenable long-term. We need a better way to build Contexts that can be more flexible and allow us to easily add new properties.

We have a few other enhancements that will be waiting on this, anything that adds capability or configurable variability to the engine and it might behave differently for different rollups.

Describe the solution you'd like
Several options including building a factory/builder pattern, adding a Fluent API design, eschewing constructors for setting properties and just setting them directly after construction.

Find something that works well and is clean and refactor out the old ways from both the engine and anywhere it is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants