Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOAP is very slow on FLAMINGO high-res. high-z #67

Open
MatthieuSchaller opened this issue Jan 29, 2024 · 2 comments
Open

SOAP is very slow on FLAMINGO high-res. high-z #67

MatthieuSchaller opened this issue Jan 29, 2024 · 2 comments

Comments

@MatthieuSchaller
Copy link
Member

MatthieuSchaller commented Jan 29, 2024

Running the default script in the repo, the code times out after 72hours and seems to be very far from having completed.

@jchelly
Copy link
Collaborator

jchelly commented Jan 29, 2024

The changes in #64 might help with this. We're sorting the particles by radius more times than necessary and passing all of the particles in the largest aperture to every calculation. We should refactor it to do the sorting at a higher level in the call stack then we can identify the subset of particles corresponding to each aperture and only process those.

We could also do some profiling on subsets of halos to see if there's anything very slow inside the property calculations.

@jchelly
Copy link
Collaborator

jchelly commented Jan 29, 2024

The fixed physical apertures are a problem too. The amount of work to do per halo will scale as (1+z)^3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants