Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation of the smoothing lengths #72

Open
loikki opened this issue Aug 18, 2020 · 2 comments
Open

Generation of the smoothing lengths #72

loikki opened this issue Aug 18, 2020 · 2 comments

Comments

@loikki
Copy link
Collaborator

loikki commented Aug 18, 2020

Hi,

When generating some initial conditions, you recommend in the documentation the following command:

# Generate initial guess for smoothing lengths based on MIPS
x.gas.generate_smoothing_lengths(boxsize=boxsize, dimension=3)

Here, it only works for a uniform box. Thus I think it would be nice to be more general and use the function in the visualization. It might be a good idea to keep both as the current implementation is a lot faster than the visualization one. Maybe we can add an argument to the function in order to mention if the box is uniform or not.

@mladenivkovic
Copy link
Collaborator

If you need it quickly, there is a workaround with the IC generator that I was working on.

@loikki
Copy link
Collaborator Author

loikki commented Aug 19, 2020

No need, I am directly accessing the function in the visualization module. This is simply a request in order to improve the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants