Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke Github Action #92

Open
jonaprieto opened this issue Jan 9, 2023 · 4 comments
Open

Smoke Github Action #92

jonaprieto opened this issue Jan 9, 2023 · 4 comments

Comments

@jonaprieto
Copy link

Many projects living on Github could get the benefit of Smoke for testing in the CIs if there is an easy Smoke Github action. Maybe a starting point is: https://github.com/rwe/actions-hlint-run

https://docs.github.com/en/actions/creating-actions.

@jonaprieto
Copy link
Author

The following could be used in a GitHub workflow to setup the binary smoke without further complications. Maybe consider including this in the README.

    - name: Download Smoke binary
        uses: jaxxstorm/action-install-gh-release@v1.9.0
        with:
          repo: SamirTalwar/smoke
          tag: v2.3.1
          cache: enable
          extension-matching: disable
          rename-to: smoke
          chmod: 0755

@SamirTalwar
Copy link
Owner

Looks good; please feel free to submit a PR.

@jonaprieto
Copy link
Author

I'll do it tomorrow. Btw, can you please make a new release?

@SamirTalwar
Copy link
Owner

Yeah, I'd like to do that. However, the current code on main introduces a dependency on ICU4C, and I need to make sure that this doesn't break everything on various setups, so it requires more manual testing than usual. (If it does, I will need to figure out another approach to regular expressions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants