Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand get_dropdown_options() #16

Open
4 tasks
Samlant opened this issue Mar 4, 2023 · 0 comments
Open
4 tasks

Expand get_dropdown_options() #16

Samlant opened this issue Mar 4, 2023 · 0 comments
Assignees
Labels
improvement Improvements or additions to already-existing code---not part of new features/requests

Comments

@Samlant
Copy link
Owner

Samlant commented Mar 4, 2023

Build upon get_dropdown_options() so that adding more carriers is easy and more extensible rather than just creating a list. This will be better as new carriers will only need to be added once, and it will be automatically sorted as a potential redundant carrier or as a normal, single carrier.

Steps to take:

  • Revise get_dropdown_options() from a list() into a dict() like {carrier_name:'', potential_redundancy:bool, var:'', text_to_display:''}, and change it to a private method.
  • Add method in model.py/Model class to divide potential redundant carriers from single submissions.
  • Use Presenter class to get carriers from Model class
  • Create a _create_variable() fn to create variable name to be used in checkbox
@Samlant Samlant added the improvement Improvements or additions to already-existing code---not part of new features/requests label Mar 4, 2023
@Samlant Samlant self-assigned this Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements or additions to already-existing code---not part of new features/requests
Projects
None yet
Development

No branches or pull requests

1 participant