Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate ConfigUpdater class to be called from each module separately, rather than one master instance passed around like a drunk wife. #85

Open
Samlant opened this issue Oct 11, 2023 · 0 comments
Assignees
Labels
improvement Improvements or additions to already-existing code---not part of new features/requests question Further information will need to be researched

Comments

@Samlant
Copy link
Owner

Samlant commented Oct 11, 2023

Description, issue

ConfigUpdater needs to be passed around numerous times to numerous modules & functions, when it could simply be imported then called on an as-needed basis.

Solution

Import what's necessary within each module, then call the needed methods.

Alternatives

Insert the config Updater module within the init.py file so that it can be a global namespace (safe in this case) and easily called from anywhere. --> may be a little excessive depending on how concise the above solution is written.

Additional context

Other alternatives may need to be researched prior to settling on any one idea.

@Samlant Samlant added question Further information will need to be researched improvement Improvements or additions to already-existing code---not part of new features/requests labels Oct 11, 2023
@Samlant Samlant self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements or additions to already-existing code---not part of new features/requests question Further information will need to be researched
Projects
None yet
Development

No branches or pull requests

1 participant