Sunken Temple appears on lists as "undefined"

[wodim]

https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=1417

Also on items:

https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?item=10454

[Sarjuuk]

probably still using the open world area id for sunken temple.

[wodim]

There are other zones that are undefined. Champion's Hall: https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=2918

[wodim]

The Great Sea: https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=207 (even though this looks more like Deadmines. I'm not sure what's up with that)

[jackpoz]

I re-run Calculate.Creature.Zone.Area.Data and aowow sql, undefined seems to have disappeared in all the links mentioned above

[jackpoz]

now that I re-run the aowow sql setup, this issue appeared again (and should be re-opened)

[jackpoz]

@Sarjuuk if I check https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=1417 I see the zone is Sunken Temple and has id 1417.
If I click on the first mob https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?npc=5722 and check in world.creature is has zoneId and areaId 1477 (notice it's 1477, not 1417).

aowow/static/js/locale_enus.js

Line 2037 in c65bd88

1477: 'Sunken Temple',

shows 1477 for Sunken Temple , while

aowow/static/js/locale_enus.js

Line 398 in c65bd88

[1417, "Sunken Temple"],

shows 1417.
SELECT * FROM creature WHERE zoneid = 1417 OR areaId = 1417; gives 0 results.

Is there a typo in the static js files ?

https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=2918 zone 2918 is missing from

aowow/static/js/locale_enus.js

Line 1970 in c65bd88

var g_zones = {

, is it supposed to be in that array ?

[Sarjuuk]

MariaDB [sarjuuk_aowow]> select * from dbc_areatable where id in (1477, 1417);
+------+-------+-----------+-------+---------------+-----------+----------------+---------------------------+-------------------------+----------------------------+-----------+--------------------------+-------------------+------------------+
| id   | mapId | areaTable | flags | soundAmbience | zoneMusic | zoneIntroMusic| name_loc0                 | name_loc2               | name_loc3   | name_loc4 | name_loc6                | name_loc8         | factionGroupMask |
+------+-------+-----------+-------+---------------+-----------+----------------+---------------------------+-------------------------+----------------------------+-----------+--------------------------+-------------------+------------------+
| 1417 |   109 |         0 |     0 |             0 |         0 |              0| Sunken Temple             | Temple englouti         | Versunkener Tempel   | ?????     | Templo Sumergido         | ?????????? ????   |                0 |
| 1477 |   109 |         0 |     0 |            33 |         3 |              0| The Temple of Atal'Hakkar | Le temple d'Atal'Hakkar | Der Tempel von Atal'Hakkar | ??????    | El Templo de Atal'Hakkar | ???? ????'??????? |                0 |
+------+-------+-----------+-------+---------------+-----------+----------------+---------------------------+-------------------------+----------------------------+-----------+--------------------------+-------------------+------------------+
2 rows in set (0.025 sec)```
its a zone on the same instance map and it has me weirded out since day one.

[jackpoz]

well

aowow/static/js/global.js

Line 8528 in c65bd88

$WH.ae(a, $WH.ct(g_zones[zoneId]));

is the one returning "undefined", maybe better to keep the zone id if the name is not found in the js.

in addition to that it might be good to refresh the list of zones as there are quite a few missing

what about something like

SELECT CONCAT(LPAD(id, 4, " "), ": '", REPLACE(name_loc0, '\'', '\\\''), "',") FROM aowow.aowow_zones;

to get the zones from the db into the js ? is there a reason to exclude some zones ?

[jackpoz]

I opened a PR at TrinityCore#41 (maybe I should I opened it on this repo but I noticed too late).

I applied it on tcubuntu, you can see the result by clearing your browser cache and visiting these urls:

• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=1417
• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?item=10454
• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=2918
• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=207