Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct comments in prolongation #21

Open
mknaranja opened this issue Mar 29, 2023 · 0 comments
Open

Correct comments in prolongation #21

mknaranja opened this issue Mar 29, 2023 · 0 comments
Labels
enhancement Improvement of current functionality

Comments

@mknaranja
Copy link
Member

I think in https://github.com/mknaranja/GMGPolar/blob/ddc23c2df1f424ced9a8c905f35dc43e8308bc3e/src/prolongation.cpp#L799, we should write no bottom_left and no_top_right.

Furthermore the comment https://github.com/mknaranja/GMGPolar/blob/ddc23c2df1f424ced9a8c905f35dc43e8308bc3e/src/prolongation.cpp#L1093 is probably wrong and should be removed (as other uncessary comments of 1/2 after val=0.5).

For cases like val = k_prev * denum; // 1/2 we should write val = k_prev * denum; // isotrop: 1/2
@mknaranja mknaranja added the enhancement Improvement of current functionality label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of current functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mknaranja