Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 | Feature request]: Port: Shamir-based shared recovery device #6090

Closed
13 tasks done
mmmarcos opened this issue Jan 5, 2024 · 3 comments · Fixed by #9349
Closed
13 tasks done

[🚀 | Feature request]: Port: Shamir-based shared recovery device #6090

mmmarcos opened this issue Jan 5, 2024 · 3 comments · Fixed by #9349
Assignees
Labels
C-Feature-Request Category: A feature request for Parsec v3-porting Porting from v2 to v3
Milestone

Comments

@mmmarcos
Copy link
Contributor

mmmarcos commented Jan 5, 2024

Shamir-based shared recovery device is described in RFC 1000.

It was implemented for the V2 branch in the following PRs:

It must be ported to the V3 branch (master).

NOTE: V2 implementation was CLI-based, so the GUI part (#8671) is out of scope for the moment.

Task List

The GUI would not be implemented right now, so we can leave the following issue for later:

Test protocol

Setup

TODO: Describe how to local setup for testing this feature (testbed ? local server ? ...)

Tests

TODO: List some test cases to be performed when reviewing the feature.

@AureliaDolo
Copy link
Contributor

With @vxgmichel we discussed the possibility of adding a few checks that are technically valid but make the shamir questionable:

  • if a recipient has strictly more than threshold (exactly threshold will have the same behavior)
  • if a recipient can use the setup on their own (ex: only one recipient, one recipient has threshold shares)

@mmmarcos
Copy link
Contributor Author

@vxgmichel I've added a Test protocol section to the issue description. Please complete so we can use it to test the feature when its finished.

@AureliaDolo
Copy link
Contributor

Before closing, we should add the corresponding newsfragment (see #9232 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature-Request Category: A feature request for Parsec v3-porting Porting from v2 to v3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants