Connection used by migrations loaded from elsewhere

[fabioluciano]

Motivation

I'm using SeaORM to create the databases to a CLI app. In the current implementation, the DATABASE_URL variable is loaded from .env file, using dotenv crate.

sea-orm/sea-orm-migration/src/cli.rs

Lines 11 to 20 in e005626

	pub async fn run_cli<M>(migrator: M)
	where
	M: MigratorTrait,
	{
	dotenv().ok();
	let url = std::env::var("DATABASE_URL").expect("Environment variable 'DATABASE_URL' not set");
	let db = &Database::connect(&url).await.unwrap();
	let app = build_cli();
	get_matches(migrator, db, app).await;
	}

And, if i need to migrate the database, using, for example, a configuration file, other then .env, i cant.

Proposed Solutions

Change the method signature to accept a connection, instead of load from dotenv directly.

Something like

pub async fn run_cli<M>(migrator: M, connection: DatabaseConnection)
where
    M: MigratorTrait,
{
    let app = build_cli();
    get_matches(migrator, &connection, app).await;
}

[fabioluciano]

I tried to implement the solution in a new pull request, but i dont know how to implement the connection in actix and in the other frameworks in the test scenarios.

[billy1624]

Hey @fabioluciano, thanks for the suggestion and contribution! If you want to run migration on startup, you can refer to our Actix examples. Basically, you can initialize the connection then pass it into methods in MigratorTrait to run the migrations. So actually you don't need the migration CLI.

sea-orm/examples/actix_example/src/main.rs

Lines 173 to 176 in 3f90c09

	// establish connection to database and apply migrations
	// -> create post table if not exists
	let conn = sea_orm::Database::connect(&db_url).await.unwrap();
	Migrator::up(&conn, None).await.unwrap();

[fabioluciano]

Ow.... Let me try this 👯

[fabioluciano]

Ow! Worked! Thank you very much @billy1624

[billy1624]

Welcome! :D