Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ComfUI Update broke your Node. #142

Open
Piscabo opened this issue Apr 7, 2024 · 7 comments
Open

New ComfUI Update broke your Node. #142

Piscabo opened this issue Apr 7, 2024 · 7 comments

Comments

@Piscabo
Copy link

Piscabo commented Apr 7, 2024

Is there a fix on the way?
ComfyUI Revision: 2115 [0a030098] | Released on '2024-04-06'

Searge-SDXL v4.3.1 in H:\ComfyUI\custom_nodes\SeargeSDXL
Traceback (most recent call last):
File "H:\ComfyUI\nodes.py", line 1889, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\ComfyUI\custom_nodes\SeargeSDXL_init
.py", line 35, in
from .searge_sdxl import SEARGE_CLASS_MAPPINGS, SEARGE_DISPLAY_NAME_MAPPINGS
File "H:\ComfyUI\custom_nodes\SeargeSDXL\searge_sdxl.py", line 54, in
from .modules.magic_box import SeargeMagicBox
File "H:\ComfyUI\custom_nodes\SeargeSDXL\modules\magic_box.py", line 38, in
from .stage_latent_detailer import SeargeStageLatentDetailer
File "H:\ComfyUI\custom_nodes\SeargeSDXL\modules\stage_latent_detailer.py", line 29, in
from comfy.sample import prepare_mask
ImportError: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\comfy\sample.py)

Cannot import H:\ComfyUI\custom_nodes\SeargeSDXL module for custom nodes: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\comfy\sample.py)

"1.3 seconds (IMPORT FAILED): H:\ComfyUI\custom_nodes\SeargeSDXL"

@hashmil
Copy link

hashmil commented Apr 7, 2024

i'm having the same issue!

Searge-SDXL v4.3.1 in /Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL
Traceback (most recent call last):
  File "/Users/hash.milhan/ComfyUI/nodes.py", line 1864, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/__init__.py", line 35, in <module>
    from .searge_sdxl import SEARGE_CLASS_MAPPINGS, SEARGE_DISPLAY_NAME_MAPPINGS
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/searge_sdxl.py", line 54, in <module>
    from .modules.magic_box import SeargeMagicBox
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/modules/magic_box.py", line 38, in <module>
    from .stage_latent_detailer import SeargeStageLatentDetailer
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/modules/stage_latent_detailer.py", line 29, in <module>
    from comfy.sample import prepare_mask
ImportError: cannot import name 'prepare_mask' from 'comfy.sample' (/Users/hash.milhan/ComfyUI/comfy/sample.py)

Cannot import /Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL module for custom nodes: cannot import name 'prepare_mask' from 'comfy.sample' (/Users/hash.milhan/ComfyUI/comfy/sample.py)

Edit - this seems to have fixed it in the short term: #137 (comment)

@huwhitememes
Copy link

This is what happened to me also 😢

@oktetopython
Copy link

Traceback (most recent call last):
File "H:\ComfyUI\ComfyUI\nodes.py", line 1864, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL_init
.py", line 35, in
from .searge_sdxl import SEARGE_CLASS_MAPPINGS, SEARGE_DISPLAY_NAME_MAPPINGS
File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL\searge_sdxl.py", line 54, in
from .modules.magic_box import SeargeMagicBox
File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL\modules\magic_box.py", line 38, in
from .stage_latent_detailer import SeargeStageLatentDetailer
File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL\modules\stage_latent_detailer.py", line 29, in
from comfy.sample import prepare_mask
ImportError: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\ComfyUI\comfy\sample.py)

Cannot import H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL module for custom nodes: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\ComfyUI\comfy\sample.py)

@hashmil
Copy link

hashmil commented Apr 8, 2024

this PR is supposed to fix it - #140

@stephantual
Copy link

Confirmed and reconfirmed :). Thanks for the PR, hopefully it gets pushed in soon.

@0xcyph
Copy link

0xcyph commented Apr 8, 2024

any updates? : ) cant use any LCM rn : (

@stephantual
Copy link

it's fixed now, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants