Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated SiteStatsUpdate constructor, use SiteStatsUpdate::factory() instead #35

Open
xSavitar opened this issue Apr 13, 2022 · 0 comments

Comments

@xSavitar
Copy link

xSavitar commented Apr 13, 2022

The code here:

$ssUpdate = new SiteStatsUpdate( 0, 0, 0, 0, 1 );
should be updated to something like:

$ssUpdate = SiteStatsUpdate::factory( [
	'edit' =>       0,
	'articles' => 0,
	'pages' =>   0,
	'users' =>    1,
] );

Per the Wikimedia Code Search tool, this is the only repo doing this: https://codesearch.wmcloud.org/search/?q=new%20SiteStatsUpdate&i=nope&files=&excludeFiles=&repos=

@xSavitar xSavitar changed the title Avoid deprecated use of new SiteStatsUpdate(), use SiteStatsUpdate::factory() instead. Avoid deprecated use of SiteStatsUpdate constructor, use SiteStatsUpdate::factory() instead. Apr 13, 2022
@xSavitar xSavitar changed the title Avoid deprecated use of SiteStatsUpdate constructor, use SiteStatsUpdate::factory() instead. Avoid deprecated SiteStatsUpdate constructor, use SiteStatsUpdate::factory() instead Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants