From ec1f5b2a29782eb2645b7d55cb73b8e44c45c207 Mon Sep 17 00:00:00 2001 From: Lucas C Date: Mon, 12 Feb 2024 16:54:27 +0100 Subject: [PATCH] XWIKI-21521: DefaultSkin form should be accessible (#2642) * Wrapped the pretty name in a label which is bound to the form field with its `for` attribute * Replaced the hard-coded reference with a call to the object number. --- .../src/main/resources/SkinsCode/XWikiSkinsSheet.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-ui/src/main/resources/SkinsCode/XWikiSkinsSheet.xml b/xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-ui/src/main/resources/SkinsCode/XWikiSkinsSheet.xml index 0c14c97b85bf..b37222669c8c 100644 --- a/xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-ui/src/main/resources/SkinsCode/XWikiSkinsSheet.xml +++ b/xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-ui/src/main/resources/SkinsCode/XWikiSkinsSheet.xml @@ -80,7 +80,7 @@ #set ($class = $doc.getObject($className).xWikiClass) #foreach ($prop in $class.properties) #if ($prop.classType != 'TextArea') - ; $services.rendering.escape($prop.prettyName, 'xwiki/2.1') + ; {{html}}<label for="${className}_$escapetool.xml($doc.getObject($className).getNumber())_$escapetool.xml($prop.name)">$escapetool.xml($prop.prettyName)</label>{{/html}} : #if($prop.name == 'logo')## Avoid line break {{attachmentSelector classname="${className}" property="${services.rendering.escape($prop.name, 'xwiki/2.1')}" filter="png,jpg,gif,svg" displayImage="true"/}}## Avoid line break #else$doc.display($prop.name)#end