Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TMDBHelper crashes when trying to open context menu on a movie inside Cast&More, but only in a very specific circumstance. Possible Memory Leak. Bug caused by Auramod Widget. #268

Open
movianlost opened this issue Jul 19, 2022 · 1 comment
Labels
bug Something isn't working High Priority

Comments

@movianlost
Copy link

When I'm in the Home page and I go to a widget and select a movie, then click on Cast&More then go Similar or Recommended etc, and I go to a movie and long press to bring the context menu, I get a tmdbHelper error as shown in the video below.

tmdbHelper.Error.mp4

Here is the log from the above error:
https://gist.githubusercontent.com/movianlost/57b95b8d50ba08b497c7d78e086c8e44/raw/4643ac3f8e8b02e5bfadb9a055bfa9de0ff71bbf/kodi.log

Note that I have tried this on two devices and I get the same error. And as you can see from the log, there is a warning about memory leak.

Now if I repeat the same thing, but instead of choosing a movie in the widget in the home screen, I instead click on the next page to show me more movies, as you know, even though the page may look similar, but the difference is that right now I'm using the tmdbHelper addon itself, whereas in the first example I was using Auramod widget. So I repeat the same thing as I did in the first example and I don't get any errors, here is the video.

temdbHelper.working.fine.mp4

The only difference between the two examples is that one was using tmdbHelper directly whereas the other was using Auramod widget, so there is something in the way Auramod widget in home screen is configured that gives this error.

@movianlost movianlost changed the title [BUG] TMDBHelper crashes when trying to open context menu on a movie inside Cast&More, but only in a very specific circumstance. Possible Memory Leak [BUG] TMDBHelper crashes when trying to open context menu on a movie inside Cast&More, but only in a very specific circumstance. Possible Memory Leak. Bug caused by Auramod Widget. Jul 19, 2022
@inb4after inb4after added bug Something isn't working High Priority labels Jul 19, 2022
@jojobrogess
Copy link

Similar to second Bug in #232 (comment)

I also reported another issue:

There also seems to be a bug when you try to use the context menu on items inside that view:
You get a error notification, and if you continue on and select information, it takes you there but you loose focus.

bandicam.2022-03-07.02-07-20-091.mp4

To which he responded:

The TMDbHelper error on context menu is likely due to AuraMod relying on a $VAR skin variable nested inside another skin variable to set tmdb_type=. The problem is that when a modal dialog pops-up (like context menu for example) then Kodi will only evaluate the parent variable, so any nested child variable becomes blank (hence the error because tmdbhelper needs a type of content to call that particular list). The child variable being blank on a modal dialog is a long standing Kodi bug that hasn't been fixed, so skins needs to work around it by not nesting important variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority
Projects
None yet
Development

No branches or pull requests

3 participants