From a9ebc5085f02f712922b99fb9ec235dbe96afb44 Mon Sep 17 00:00:00 2001 From: Aditya Gannavarapu Date: Tue, 2 Jan 2024 10:44:50 +0530 Subject: [PATCH 1/6] Update Readme --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index 348e481..de0c690 100644 --- a/README.md +++ b/README.md @@ -48,6 +48,12 @@ You can configure crucible icons using props. Note: `fill` prop is only valid for icons `BadgeWithTick`, `CircleWithCross`, `CircleWithTick`. +### Contributing to the package + +- Create an issue with the icon/s that needs to be added to the package +- The issue is reviewed and a PR with all the necessary changes is raised to `main` +- Package is published to npm on merge of the PR + ### Guidelines to add icons - Add svg files to respective folders of `svgLineIcons` and `svgPictograms` in `assets/icons/svgs`. @@ -60,3 +66,8 @@ Note: `fill` prop is only valid for icons `BadgeWithTick`, `CircleWithCross`, `C - When names changed or new icons added update them in `iconNames` file. - Update the styles of the icons if changed or of new icons added in `iconSpecificStyles` file. - To build, run `yarn build` and then for storybook run `yarn storybook` + +### Points to note when raising PR + +- Update the version of the current package in `package.json` +- Before pushing it to new branch, run `yarn build` to build the package \ No newline at end of file From dad52b7241fc2b69f016a3b936d493479ca968c4 Mon Sep 17 00:00:00 2001 From: pankaj0308 <105493144+pankaj0308@users.noreply.github.com> Date: Thu, 29 Feb 2024 17:39:14 +0530 Subject: [PATCH 2/6] Add line icon (#15) * add ArrowInsideBox line icon * Fix indentation --------- Co-authored-by: pankajdwivedi --- .../svgs/svgLineIcons/ArrowInsideBox.svg | 18 +++ .../icons/svgs/svgPictograms/MobilityCard.svg | 126 ++++++++++-------- package.json | 2 +- src/icons/reactLineIcons/ArrowInsideBox.tsx | 50 +++++++ src/icons/reactLineIcons/index.ts | 1 + src/iconsIndex.tsx | 1 + 6 files changed, 144 insertions(+), 54 deletions(-) create mode 100644 assets/icons/svgs/svgLineIcons/ArrowInsideBox.svg create mode 100644 src/icons/reactLineIcons/ArrowInsideBox.tsx diff --git a/assets/icons/svgs/svgLineIcons/ArrowInsideBox.svg b/assets/icons/svgs/svgLineIcons/ArrowInsideBox.svg new file mode 100644 index 0000000..c0c4db0 --- /dev/null +++ b/assets/icons/svgs/svgLineIcons/ArrowInsideBox.svg @@ -0,0 +1,18 @@ + + + + + + + + diff --git a/assets/icons/svgs/svgPictograms/MobilityCard.svg b/assets/icons/svgs/svgPictograms/MobilityCard.svg index 41a6060..84605d3 100644 --- a/assets/icons/svgs/svgPictograms/MobilityCard.svg +++ b/assets/icons/svgs/svgPictograms/MobilityCard.svg @@ -1,59 +1,79 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/package.json b/package.json index 0cea6a4..b26c638 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@setu/crucible-icons", - "version": "1.0.6", + "version": "1.0.7", "description": "Crucible Icons package", "license": "MIT", "main": "./dist/cjs/index.js", diff --git a/src/icons/reactLineIcons/ArrowInsideBox.tsx b/src/icons/reactLineIcons/ArrowInsideBox.tsx new file mode 100644 index 0000000..d9dfe0e --- /dev/null +++ b/src/icons/reactLineIcons/ArrowInsideBox.tsx @@ -0,0 +1,50 @@ +// GENERATED BY /script/build.js +// DO NOT EDIT MANUALLY + +import * as React from "react"; +import { LineIconProps } from "../../types"; +import { SVGLineIconWrapper } from "../../styles"; + +export const ArrowInsideBox = React.forwardRef( + ({ width = 24, height = 24, ...props }, forwardedRef) => { + return ( + + + + + + + + + ); + } +); + +ArrowInsideBox.displayName = "ArrowInsideBox"; + +export default ArrowInsideBox; diff --git a/src/icons/reactLineIcons/index.ts b/src/icons/reactLineIcons/index.ts index 5d0d4f5..22a06fe 100644 --- a/src/icons/reactLineIcons/index.ts +++ b/src/icons/reactLineIcons/index.ts @@ -1,4 +1,5 @@ export { default as Alphabets } from "./Alphabets"; +export { default as ArrowInsideBox } from "./ArrowInsideBox"; export { default as ArrowLeft } from "./ArrowLeft"; export { default as ArrowRight } from "./ArrowRight"; export { default as ArrowsOpposite } from "./ArrowsOpposite"; diff --git a/src/iconsIndex.tsx b/src/iconsIndex.tsx index b202b8b..8d53c25 100644 --- a/src/iconsIndex.tsx +++ b/src/iconsIndex.tsx @@ -196,6 +196,7 @@ export { default as eSign } from "./icons/reactPictograms/eSign"; // ReactLineIcons export { default as Alphabets } from "./icons/reactLineIcons/Alphabets"; +export { default as ArrowInsideBox } from "./icons/reactLineIcons/ArrowInsideBox"; export { default as ArrowLeft } from "./icons/reactLineIcons/ArrowLeft"; export { default as ArrowRight } from "./icons/reactLineIcons/ArrowRight"; export { default as ArrowsOpposite } from "./icons/reactLineIcons/ArrowsOpposite"; From a559441ed98cc1a503998379141f1713ef498cbc Mon Sep 17 00:00:00 2001 From: Aditya Gannavarapu Date: Fri, 8 Mar 2024 11:59:15 +0530 Subject: [PATCH 3/6] Fix types warning (#16) * add ArrowInsideBox line icon * Fix indentation * Fix path of types * Fix path of types --------- Co-authored-by: pankajdwivedi --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index b26c638..30cc9d5 100644 --- a/package.json +++ b/package.json @@ -1,11 +1,11 @@ { "name": "@setu/crucible-icons", - "version": "1.0.7", + "version": "1.0.8", "description": "Crucible Icons package", "license": "MIT", "main": "./dist/cjs/index.js", "module": "./dist/esm/index.js", - "types": "./dist/types/index.d.ts", + "types": "./dist/types/src/index.d.ts", "sideEffects": false, "files": [ "dist" From e08d234f00e6f2a02431a8c92b97779400ae8c3b Mon Sep 17 00:00:00 2001 From: Avinash Prajapati <76595361+avinashprj@users.noreply.github.com> Date: Tue, 2 Apr 2024 11:35:36 +0530 Subject: [PATCH 4/6] feat: add two new pictograms (#17) * feat: add two new pictograms * build: update version --- .../svgs/svgPictograms/BoxWithLeftArrow.svg | 28 +++++++ .../svgs/svgPictograms/BoxWithRightArrow.svg | 32 +++++++ package.json | 2 +- src/iconSpecificStyles.tsx | 17 +++- .../reactPictograms/BoxWithLeftArrow.tsx | 59 +++++++++++++ .../reactPictograms/BoxWithRightArrow.tsx | 83 +++++++++++++++++++ src/icons/reactPictograms/index.ts | 2 + src/iconsIndex.tsx | 2 + src/iconsNames.tsx | 4 +- 9 files changed, 223 insertions(+), 6 deletions(-) create mode 100644 assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg create mode 100644 assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg create mode 100644 src/icons/reactPictograms/BoxWithLeftArrow.tsx create mode 100644 src/icons/reactPictograms/BoxWithRightArrow.tsx diff --git a/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg b/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg new file mode 100644 index 0000000..0729d3d --- /dev/null +++ b/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg @@ -0,0 +1,28 @@ + + + + + + + + + + + + + + diff --git a/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg b/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg new file mode 100644 index 0000000..07c6d19 --- /dev/null +++ b/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg @@ -0,0 +1,32 @@ + + + + + + + + + + + + + + diff --git a/package.json b/package.json index 30cc9d5..c6ec192 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@setu/crucible-icons", - "version": "1.0.8", + "version": "1.0.9", "description": "Crucible Icons package", "license": "MIT", "main": "./dist/cjs/index.js", diff --git a/src/iconSpecificStyles.tsx b/src/iconSpecificStyles.tsx index 656f1ec..b96ffbc 100644 --- a/src/iconSpecificStyles.tsx +++ b/src/iconSpecificStyles.tsx @@ -165,6 +165,16 @@ export const iconSpecificStyles: IconStylesTypes = { secondary : "#42cacd", }, + [PictogramsNames.BoxWithLeftArrow]: { + base : "#b7cde1", + primary : "#42CACD", + }, + + [PictogramsNames.BoxWithRightArrow]: { + base : "#b7cde1", + primary : "#42CACD", + }, + [PictogramsNames.Brain]: { base : "#b7cde1", primary : "#42cacd", @@ -260,11 +270,11 @@ export const iconSpecificStyles: IconStylesTypes = { [PictogramsNames.ChatBubbles]: { base : "#b7cde1", primary : "#42CACD", - }, + }, [PictogramsNames.ChatBot]: { base : "#42CACD", primary : "#FEB452", - }, + }, [PictogramsNames.Checklist]: { base : "#b7cde1", @@ -586,7 +596,6 @@ export const iconSpecificStyles: IconStylesTypes = { base : "#b7cde1", primary : "#42CACD", }, - [PictogramsNames.Metro]: { base : "#b7cde1", primary : "#42CACD", @@ -867,7 +876,7 @@ export const iconSpecificStyles: IconStylesTypes = { base : "#b7cde1", primary : "#09cdcd", }, - + [PictogramsNames.RingWithDiamond]: { base : "#FEB452", primary : "#42CACD", diff --git a/src/icons/reactPictograms/BoxWithLeftArrow.tsx b/src/icons/reactPictograms/BoxWithLeftArrow.tsx new file mode 100644 index 0000000..fabae00 --- /dev/null +++ b/src/icons/reactPictograms/BoxWithLeftArrow.tsx @@ -0,0 +1,59 @@ +// GENERATED BY /script/build.js +// DO NOT EDIT MANUALLY + +import * as React from "react"; +import { PictogramIconProps } from "../../types"; +import { SVGPictogramWrapper } from "../../styles"; +import { PictogramsNames } from "../../iconsNames"; + +export const BoxWithLeftArrow = React.forwardRef( + ({ width = 64, height = 64, ...props }, forwardedRef) => { + return ( + + + + + + + + + + + + + + + ); + } +); + +BoxWithLeftArrow.displayName = "BoxWithLeftArrow"; + +export default BoxWithLeftArrow; diff --git a/src/icons/reactPictograms/BoxWithRightArrow.tsx b/src/icons/reactPictograms/BoxWithRightArrow.tsx new file mode 100644 index 0000000..9a30b69 --- /dev/null +++ b/src/icons/reactPictograms/BoxWithRightArrow.tsx @@ -0,0 +1,83 @@ +// GENERATED BY /script/build.js +// DO NOT EDIT MANUALLY + +import * as React from "react"; +import { PictogramIconProps } from "../../types"; +import { SVGPictogramWrapper } from "../../styles"; +import { PictogramsNames } from "../../iconsNames"; + +export const BoxWithRightArrow = React.forwardRef( + ({ width = 64, height = 64, ...props }, forwardedRef) => { + return ( + + + + + + + + + + + + + + + ); + } +); + +BoxWithRightArrow.displayName = "BoxWithRightArrow"; + +export default BoxWithRightArrow; diff --git a/src/icons/reactPictograms/index.ts b/src/icons/reactPictograms/index.ts index 0816664..0536d59 100644 --- a/src/icons/reactPictograms/index.ts +++ b/src/icons/reactPictograms/index.ts @@ -22,7 +22,9 @@ export { default as BookWithKarmaSymbol } from "./BookWithKarmaSymbol"; export { default as BoxWithBraces } from "./BoxWithBraces"; export { default as BoxWithCash } from "./BoxWithCash"; export { default as BoxWithCoin } from "./BoxWithCoin"; +export { default as BoxWithLeftArrow } from "./BoxWithLeftArrow"; export { default as BoxWithMobile } from "./BoxWithMobile"; +export { default as BoxWithRightArrow } from "./BoxWithRightArrow"; export { default as BoxWithShapes } from "./BoxWithShapes"; export { default as BoxWithStar } from "./BoxWithStar"; export { default as Brain } from "./Brain"; diff --git a/src/iconsIndex.tsx b/src/iconsIndex.tsx index 8d53c25..aa8c547 100644 --- a/src/iconsIndex.tsx +++ b/src/iconsIndex.tsx @@ -25,7 +25,9 @@ export { default as BookWithKarmaSymbol } from "./icons/reactPictograms/BookWith export { default as BoxWithBraces } from "./icons/reactPictograms/BoxWithBraces"; export { default as BoxWithCash } from "./icons/reactPictograms/BoxWithCash"; export { default as BoxWithCoin } from "./icons/reactPictograms/BoxWithCoin"; +export { default as BoxWithLeftArrow } from "./icons/reactPictograms/BoxWithLeftArrow"; export { default as BoxWithMobile } from "./icons/reactPictograms/BoxWithMobile"; +export { default as BoxWithRightArrow } from "./icons/reactPictograms/BoxWithRightArrow"; export { default as BoxWithShapes } from "./icons/reactPictograms/BoxWithShapes"; export { default as BoxWithStar } from "./icons/reactPictograms/BoxWithStar"; export { default as Brain } from "./icons/reactPictograms/Brain"; diff --git a/src/iconsNames.tsx b/src/iconsNames.tsx index f21b7e8..dee5e6e 100644 --- a/src/iconsNames.tsx +++ b/src/iconsNames.tsx @@ -26,6 +26,8 @@ export const PictogramsNames = { BoxWithMobile : "BoxWithMobile" , BoxWithShapes : "BoxWithShapes" , BoxWithStar : "BoxWithStar" , + BoxWithLeftArrow : "BoxWithLeftArrow", + BoxWithRightArrow : "BoxWithRightArrow", BSA : "BSA", Brain : "Brain" , Briefcase : "Briefcase" , @@ -46,7 +48,7 @@ export const PictogramsNames = { ChatBubbles : "ChatBubbles", Checklist : "Checklist" , Chord : "Chord" , - CircleWithCross : "CircleWithCross", + CircleWithCross : "CircleWithCross", CircleWithPlus : "CircleWithPlus", CircleWithStarAndLines : "CircleWithStarAndLines" , CircleWithTick : "CircleWithTick", From bb9654a58082ace63fc394aa78854e09f60ef0a2 Mon Sep 17 00:00:00 2001 From: Aditya Gannavarapu Date: Tue, 30 Apr 2024 00:30:59 +0530 Subject: [PATCH 5/6] Add icons --- .../svgs/svgPictograms/BoxWithLeftArrow.svg | 20 ++++-- .../svgs/svgPictograms/BoxWithRightArrow.svg | 64 +++++++++++++++---- 2 files changed, 66 insertions(+), 18 deletions(-) diff --git a/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg b/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg index 0729d3d..d09caa9 100644 --- a/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg +++ b/assets/icons/svgs/svgPictograms/BoxWithLeftArrow.svg @@ -10,19 +10,29 @@ } .primary { - fill: #42CACD; + fill: #42cacd; } - + - + diff --git a/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg b/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg index 07c6d19..6456145 100644 --- a/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg +++ b/assets/icons/svgs/svgPictograms/BoxWithRightArrow.svg @@ -10,23 +10,61 @@ } .primary { - fill: #42CACD; + fill: #42cacd; } - - - + + + - - - + + + From e0c0bff2bcc23408eb4395f3b40ac5e3670f5ba2 Mon Sep 17 00:00:00 2001 From: Aditya Gannavarapu Date: Tue, 30 Apr 2024 00:43:54 +0530 Subject: [PATCH 6/6] Add GH actions --- .github/workflows/slack_notification.yml | 26 ++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .github/workflows/slack_notification.yml diff --git a/.github/workflows/slack_notification.yml b/.github/workflows/slack_notification.yml new file mode 100644 index 0000000..1b4dcf2 --- /dev/null +++ b/.github/workflows/slack_notification.yml @@ -0,0 +1,26 @@ +name: Slack Notification on PR Merge + +on: + pull_request: + types: + - closed + branches: + - 'github-workflow' + +jobs: + notify_on_merge: + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 + + - name: Extract version from package.json + id: extract_version + run: echo ::set-output name=version::$(jq -r '.version' package.json) + + - name: Send message to Slack + env: + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + run: | + curl -X POST -H 'Content-type: application/json' --data '{"text": "Version: ${{ steps.extract_version.outputs.version }}\nPR ID: ${{ github.event.pull_request.number }}"}' $SLACK_WEBHOOK_URL