Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPT2Codec suggestion #2

Open
Deltrego opened this issue Apr 20, 2021 · 0 comments
Open

GPT2Codec suggestion #2

Deltrego opened this issue Apr 20, 2021 · 0 comments

Comments

@Deltrego
Copy link

A small improvement on gpt2's bpe ranking code (GPT2Codec.java): byte decoding can be performed at load time on every key from encoder.json and every space-separated pair from vocab.bpe (after invoking split(" ") on the string).
This avoids having to perform the byte conversion every time in memory.
Tested with my own implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Deltrego