Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a size option to default balloon options. #249

Closed
SimonStnn opened this issue Jul 2, 2024 · 0 comments · Fixed by #246
Closed

Add a size option to default balloon options. #249

SimonStnn opened this issue Jul 2, 2024 · 0 comments · Fixed by #246
Assignees
@SimonStnn
Labels
enhancement New feature or request

Comments

@SimonStnn
Copy link
Owner

Also allow subclasses to easely set the balloon size.

It should be a threshold like the swing and wave. It should be a [number, number].
@SimonStnn SimonStnn added the enhancement New feature or request label Jul 2, 2024
@SimonStnn SimonStnn self-assigned this Jul 2, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Pop-a-loon Jul 2, 2024
@SimonStnn SimonStnn moved this from Backlog to In progress in Pop-a-loon Jul 2, 2024
@SimonStnn SimonStnn moved this from In progress to In review in Pop-a-loon Jul 5, 2024
SimonStnn added a commit that referenced this issue Jul 5, 2024
@SimonStnn
Add size option to default balloon close #249
8342adf
@SimonStnn SimonStnn linked a pull request Jul 6, 2024 that will close this issue
Golden balloon #246
Merged
SimonStnn added a commit that referenced this issue Jul 7, 2024
@SimonStnn
Add size option to default balloon close #249
2d79e88
@github-project-automation github-project-automation bot moved this from In review to Done in Pop-a-loon Jul 15, 2024
SimonStnn added a commit that referenced this issue Jul 15, 2024
@SimonStnn
Revert "Add size option to default balloon close #249"
fb7fab6 
This reverts commit a19c0d3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonStnn SimonStnn

Labels
enhancement New feature or request
Projects
Pop-a-loon
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Golden balloon SimonStnn/pop-a-loon
1 participant
@SimonStnn