Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affects other appplication windows #4

Open
wolf99 opened this issue Apr 9, 2018 · 3 comments · May be fixed by #47
Open

Affects other appplication windows #4

wolf99 opened this issue Apr 9, 2018 · 3 comments · May be fixed by #47
Assignees

Comments

@wolf99
Copy link

wolf99 commented Apr 9, 2018

Seems like this is affecting some other application's windows, such as Google Chrome.

plugin version: 1.0.5
vscode version: 1.22.1
platform: Windows 7 (7601)

this bit of a screen grab shows the GitHub header bar and browser chrome with this opacity such that you can see the vscode window behind it:

image

Checked that this is the plugin causing this by disabling the plugin and restarting both vscode and the the browser. Annoyingly for reproduction, it doesn't seem to come back nearly as regularly - just re-enabling the plugin and restarting the applications doesn't seem to have shown the problem again at the moment but I played around with this a few days ago and it does come back in time (maybe a system restart?)

@SkaceKamen
Copy link
Owner

SkaceKamen commented Apr 9, 2018

That can happen because of the way vscode windows are detected. Right now (or at least at the moment of writing the first extension code) there is no way to get handle of vscode window from extension, so the extension just scans all windows and matches the vscode window title suffix.

There's one mistake in this algorithm that incorrectly matched windows which had vscode title in title, but not as suffix, I'll fix that. But other than that, there will always be possibility that incorrect windows get updated if the title matches.

EDIT: To clarify, there are more methods of detecting vscode windows, some may be more accurate, but harder to implement. Right now I'm using the easiest method.

SkaceKamen added a commit that referenced this issue Apr 9, 2018
@SkaceKamen SkaceKamen added the bug label Apr 9, 2018
@SkaceKamen SkaceKamen self-assigned this Apr 9, 2018
@SkaceKamen
Copy link
Owner

Published update 1.0.6, which has more strict window detection, which will hopefully eliminate some false positives. But this issue will still exist unless I switch to different detection method, so I'll leave it open.

@ghost
Copy link

ghost commented Aug 22, 2020

I accidentally made my windows completely transparent, is there anyway i can undo it?

@killcerr killcerr linked a pull request Mar 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants