Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] TC makes KubeJS fail on load #5289

Closed
carbonatek opened this issue Jan 1, 2025 · 4 comments
Closed

[1.20.1] TC makes KubeJS fail on load #5289

carbonatek opened this issue Jan 1, 2025 · 4 comments
Labels
1.20 Issue affects 1.20 Bug Issue describes unintended or broken behavior Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Mantle Issue is actually a bug in Mantle, the library Tinkers' Construct depends on Mod interaction Issue only happens when another mod is loaded Resolved Issue is fixed in code, but there is not a release with that fix yet.

Comments

@carbonatek
Copy link

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.0

Mantle Version

1.11.28

Tinkers' Construct Version

3.9.0.6

Describe your issue

I know that using large packs is probably not supported with alpha versions (in which case, I apologize, but I wanted to try it out in a more realistic scenario rather than isolated) but installing TC into my private modpack causes KubeJS to no longer load recipes.
Reloading KubeJS using /reload works though, so there's just something wrong with the initial load. Modifying any recipe, as seen in the example I've provided in "Other mods", makes KJS fail to load w/ TC.

Crash Report

https://gist.github.com/carbonatek/dcf59b871825b6496bcfbf3036cdb02a

Other mods

TC same ver, Mantle same ver, JEI 15.20.0.105 (same version), KubeJS 2001.6.5-build.16, Architectury 9.2.14, Rhino 2001.2.3-build.6.
in the testing instance isolated from the modpack, a test script in kubejs/server_scripts/example.js:

ServerEvents.recipes(event => {
     event.remove({output: 'minecraft:blaze_powder'})
})

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched open issues

@carbonatek carbonatek added Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Jan 1, 2025
@carbonatek carbonatek changed the title TC makes KubeJS fail on load [1.20.1] TC makes KubeJS fail on load Jan 1, 2025
@ChiefArug
Copy link

You can disable KubeJS running recipe stuff in parallel by setting allowAsyncStreams to false in kubejs/config/common.properties. That should resolve this.

@carbonatek
Copy link
Author

Thanks for the temporary solution :-)

@KnightMiner KnightMiner added Mantle Issue is actually a bug in Mantle, the library Tinkers' Construct depends on Mod interaction Issue only happens when another mod is loaded labels Jan 1, 2025
@KnightMiner
Copy link
Member

Seems that not everything in Mantle's tag preference system is fully multithread safe. Most of it is but I missed one spot. Should be an easy enough fix.

@KnightMiner KnightMiner added Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added and removed Unreviewed Issue is new and is awaiting the team to review it labels Jan 2, 2025
@KnightMiner KnightMiner added 1.20 Issue affects 1.20 Resolved Issue is fixed in code, but there is not a release with that fix yet. labels Jan 4, 2025
KnightMiner added a commit to SlimeKnights/Mantle that referenced this issue Jan 6, 2025
…truct#5289)

Did not think it was needed, but upon review its needed.
Also reduce the number of cache lookups needed by 1 for the uncached lookup
@KnightMiner
Copy link
Member

Fixed in Mantle 1.11.36 for 1.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Issue affects 1.20 Bug Issue describes unintended or broken behavior Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Mantle Issue is actually a bug in Mantle, the library Tinkers' Construct depends on Mod interaction Issue only happens when another mod is loaded Resolved Issue is fixed in code, but there is not a release with that fix yet.
Projects
None yet
Development

No branches or pull requests

3 participants