Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V-Minus breaks the mod because they mixin where they shouldn't mixin #5291

Closed
ModernGamingWorld opened this issue Jan 1, 2025 · 6 comments
Closed
Labels
1.20 Issue affects 1.20 Bug Issue describes unintended or broken behavior Other mod Issue is caused by another mod, and it is best fixed in the other mod Resolved Issue is fixed in code, but there is not a release with that fix yet.

Comments

@ModernGamingWorld
Copy link

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.22

Mantle Version

1.20.1-1.11.28

Tinkers' Construct Version

1.20.1-3.9.0.6

Describe your issue

I added Tinker's to my new modpack version for 1.20.1, and it crashed. I have provided the crash log and logs to help figure this out

crash-2025-01-01_16.15.20-client.txt

latest.log

Crash Report

No response

Other mods

Well I can provide this, as I don't know how else to get the mod list for you
Fun-Filled Adventure-1.0.0.zip

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

Other (specify under other mods)

Searched for known issues?

Searched open issues

@ModernGamingWorld ModernGamingWorld added Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Jan 1, 2025
@KnightMiner
Copy link
Member

You claim you reproduced this with just tinkers in the issue forum, can you upload the log with only tinkers in it?

@KnightMiner
Copy link
Member

Also, your log says you have diagonal fences. Diagonal fence mods are known to cause issues with mods that add custom glass panes like Tinkers, so you really should remove that if you want tinkers.

@ModernGamingWorld
Copy link
Author

I doubt its Diagonal fences as I am using it in my other pack with Tinkers on 1.20.1 with no issues

@KnightMiner
Copy link
Member

	at TRANSFORMER/forge@47.3.22/net.minecraftforge.registries.ForgeRegistry.getDelegateOrThrow(ForgeRegistry.java:1648)
	at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.ItemStack.<init>(ItemStack.java:148)
	at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.ItemStack.<init>(ItemStack.java:143)
	at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.ItemStack.<init>(ItemStack.java:127)
	at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.Item.handler$dmp000$vminus$getFoodProperties(Item.java:6047)
	at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.Item.m_41473_(Item.java:362)
	at TRANSFORMER/mantle@1.11.28/slimeknights.mantle.item.EdibleItem.<init>(EdibleItem.java:26)
	at TRANSFORMER/mantle@1.11.28/slimeknights.mantle.item.EdibleItem.<init>(EdibleItem.java:21)

Here is your problem. Someone is writing a mixin into getFoodProperties and constructing an item stack from it. No idea who vminus is but you will have a better idea. No idea why they have a mixin there.

We don't need to call that method in our constructor of the item, but all that method should be doing is returning a value from a vanilla field; forge has a stack sensitive constructor they can use for their mixin nonsense. So figure out who vminus is and crosspost this issue to them.

@KnightMiner KnightMiner added Other mod Issue is caused by another mod, and it is best fixed in the other mod and removed Unreviewed Issue is new and is awaiting the team to review it labels Jan 2, 2025
@carbonatek
Copy link

VMinus' issue tracker: https://github.com/lixxir/VMinus/issues

@KnightMiner KnightMiner added 1.20 Issue affects 1.20 Resolved Issue is fixed in code, but there is not a release with that fix yet. labels Jan 4, 2025
KnightMiner added a commit to SlimeKnights/Mantle that referenced this issue Jan 6, 2025
…sConstruct#5291)

Not really our problem since that getter shouldn't be doing anything beyond getting, but its a trivial enough fix.
@KnightMiner KnightMiner changed the title Added Tinker's to my 400ish Custom Modpack and it crashes V-Minus breaks the mod because they mixin where they shouldn't mixin Jan 11, 2025
@KnightMiner
Copy link
Member

KnightMiner commented Jan 20, 2025

Mantle 1.11.36 for 1.20.1 adds a workaround for this issue. Still ultimately a problem with V-Minus as there is absolutely no reason for such an intrusive mixin into the vanilla food properties getter, but as long as nothing else breaks nothing stops you from using that mod right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Issue affects 1.20 Bug Issue describes unintended or broken behavior Other mod Issue is caused by another mod, and it is best fixed in the other mod Resolved Issue is fixed in code, but there is not a release with that fix yet.
Projects
None yet
Development

No branches or pull requests

3 participants