Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe Incompatibility with Dye Depot - Breaks JEI Compat & majority of pages in guidebook #5302

Open
ambientNexus opened this issue Jan 11, 2025 · 3 comments
Labels
1.20 Issue affects 1.20 Mod interaction Issue only happens when another mod is loaded Other mod Issue is caused by another mod, and it is best fixed in the other mod Resolved Issue is fixed in code, but there is not a release with that fix yet.

Comments

@ambientNexus
Copy link

ambientNexus commented Jan 11, 2025

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.12

Mantle Version

1.11.28

Tinkers' Construct Version

3.9.0.6

Describe your issue

image
image
Any extension to the list of dyes causes a significant amount of pages in the guidebooks to error out, as the armor dyeing recipe only expects 16 entries (0-15). This makes the guidebooks completely unusable. It also breaks JEI compatibility completely.

Crash Report

No response

Other mods

Dye Depot (Apologies for the misreport in regards to dyenamics)

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues

@ambientNexus ambientNexus added 1.20 Issue affects 1.20 Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Jan 11, 2025
@ambientNexus ambientNexus changed the title Incompatibility with additional dye mods - Breaks significant amounts of pages in guidebook Incompatibility with additional dye mods - Breaks JEI Compat & majority of pages in guidebook Jan 11, 2025
@ambientNexus ambientNexus changed the title Incompatibility with additional dye mods - Breaks JEI Compat & majority of pages in guidebook Severe Incompatibility with additional dye mods - Breaks JEI Compat & majority of pages in guidebook Jan 11, 2025
@KnightMiner
Copy link
Member

Are you sure its broken with Dyenamics? I've been told that case works fine.

Dye Depot I know is broken because they do things in a really dumb way that will break 90% of mods that use dyes. But last I heard Dyenamics does things properly.

@KnightMiner KnightMiner added Not enough information Insufficient information is provided in the issue to accurately respond Mod interaction Issue only happens when another mod is loaded Other mod Issue is caused by another mod, and it is best fixed in the other mod and removed Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Jan 11, 2025
@ambientNexus
Copy link
Author

Huh, I guess it works fine with dyenamics. Last I heard all of these added dye mods used the exact same method (hence the incompatibility between them), and this is the first time I've had any issues of Dye Depot conflicting with other mods, so I guess I just assumed it also had issues with Dyenamics as well. Sorry about the misreport then.

@ambientNexus ambientNexus changed the title Severe Incompatibility with additional dye mods - Breaks JEI Compat & majority of pages in guidebook Severe Incompatibility with Dyenamics - Breaks JEI Compat & majority of pages in guidebook Jan 11, 2025
@KnightMiner
Copy link
Member

Dye Depot literally says in their CurseForge description that they will break other mods. It shouldn't be a surprise.

Anyways, if its just Dye Depot, then I've already dealt with this issue in 38207ef, will be in the next update. Doesn't fix the many other issues they cause with tinkers via our dyeable blocks, but at least our books work.

@KnightMiner KnightMiner added Resolved Issue is fixed in code, but there is not a release with that fix yet. and removed Not enough information Insufficient information is provided in the issue to accurately respond labels Jan 11, 2025
@KnightMiner KnightMiner changed the title Severe Incompatibility with Dyenamics - Breaks JEI Compat & majority of pages in guidebook Severe Incompatibility with Dye Depot - Breaks JEI Compat & majority of pages in guidebook Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Issue affects 1.20 Mod interaction Issue only happens when another mod is loaded Other mod Issue is caused by another mod, and it is best fixed in the other mod Resolved Issue is fixed in code, but there is not a release with that fix yet.
Projects
None yet
Development

No branches or pull requests

2 participants