Armor trim incompatibility

[UWUsraka132]

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.0

Mantle Version

1.11.28

Tinkers' Construct Version

3.9.0.6

Describe your issue

Tinkers' armors are incompatible with some armor trims and trim materials.

When applying a Heart trim from Geode+ using any trim material other than vanilla and Geode+, the 3D model of the armor breaks.
And the other way around, vanilla trims with Geode+ materials show a bugged 3D model.
The item models are also broken in all cases.

Crash Report

No response

Other mods

Geode+ version 1.2.5
Alex's Caves version 2.0.2
L_Ender's Cataclysm version 2.35
AllTheModium version 47.1.25-2.5.1
Biomes O' Plenty version 18.0.0.592

Tried reproducing with just Tinkers?

No

Performance Enchancers

Rubidium/Embeddium

Searched for known issues?

Searched open issues, Searched closed issues, Checked the FAQ

[KnightMiner]

That's not a tinkers issue, that's just a trim issue in general. You will see installing a geode+ trim with a non geode+ material will break on vanilla armor too. Also just checked their mod, they don't even try to make their trim work, I see nothing making textures for their trim on items not vanilla trims.

Try using the mod trimmed, it makes trim work more. And tell geode + to adds trimmed support. That will fix this

[KnightMiner]

Had our tester debug this a bit more, Geode+ just does armor trims entirely wrong. Their armor trims only work on vanilla armor for their materials on their trims. Their materials on even vanilla trim, and their trim with vanilla material are both broken on vanilla armor.

If its broken on vanilla armor, you can't expect it to work on Tinkers' Armor. Report this issue to Geode+, tell them that the mod Trimmed solves all their compatibility problems including with vanilla if they follow the steps on that mods wiki, then we can close this.

[KnightMiner]

Did some work on the modifier and the armor renderer, armor trim will no longer show missing textures if the trim has no variant for the material, will instead recolor the base trim texture using the font color of the trim material. Color might be a little off as its not the intended palette, but its better than missing.

Geode+ still needs to fix their trims to actually provide at minimum vanilla trim textures in their materials and vanilla materials textures in their patterns, if not just fully using Trimmed to add all combos automatically.

[KnightMiner]

I've added a workaround for armor trim/armor material missing compatibility in Tinkers' Construct 3.9.1.17 for 1.20.1, which includes the missing item icons in many mods adding trim.

Note that Geode+'s trim is still very broken as it doesn't even work on vanilla armor trim patterns, so you still should report this issue to them if you want that mod fixed. I've just done everything reasonable to do on my side.