Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Liquid tank displaces water, does not add it to the tank and water does not flow back #6

Open
Sefiraat opened this issue Mar 6, 2022 · 2 comments
Labels
bug Something isn't working pre-archive-issue

Comments

@Sefiraat
Copy link
Member

Sefiraat commented Mar 6, 2022

Description (Required)
When using a new liquid tank, when trying to pick up water it seems that only 1 bucket's worth will go into the tank, regardless of how many buckets are picked up. Additionally, at least visually water does not flow back after being picked up. While relogging into the server does show the water being replaced, it makes it very inconvenient to do so, and hard to work with the area if you don't.

Steps to reproduce the Issue (Required)
https://user-images.githubusercontent.com/75179680/153718325-5ae7a552-27c3-4909-8ebf-c9beeb6d9cfd.mp4

Expected behavior (Required)

the liquid tank to not leave holes in the water, and to pick up the water accounted for properly in the tank.

Server Log / Error Report

no errors in console or slimefun error folder

Environment (Required)
Minecraft Version: 1.18.1
CS-CoreLib Version: n/a
Slimefun Version: 999
Plugin Version: 160

@Sefiraat Sefiraat added bug Something isn't working pre-archive-issue labels Mar 6, 2022
@Nekosity12
Copy link

After having a player report this on our the server, the issue is that it's not actually picking up the water. Whenever you click to pick up water towards "air" (this includes other water blocks hence quotations) it will not pick it up but since the item is a bucket it is visually glitched like it did. When you right click against a block, it will pick it up just fine.

There are also other similiar issues such as it won't pick up water from waterlogged blocks, it can be filled from flowing water and finally it can't place water down in flowing water. Here's a video depicting the issue(s):
https://www.youtube.com/watch?v=4VlqarBhR1o

@Sefiraat
Copy link
Member Author

Thanks Neko, we have found the issue as you described and the fix was being worked on by Panda :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working pre-archive-issue
Projects
None yet
Development

No branches or pull requests

2 participants