Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition on SolaceErrorTopicPublisherHandler topic #9

Closed
ozangunalp opened this issue Dec 20, 2023 · 1 comment · Fixed by #14
Closed

Race condition on SolaceErrorTopicPublisherHandler topic #9

ozangunalp opened this issue Dec 20, 2023 · 1 comment · Fixed by #14
Assignees

Comments

@ozangunalp
Copy link
Collaborator

https://github.com/SolaceCoEExt/solace-quarkus/blob/76d9f4fe7052f2c4e5eff06ed9077de93036ca6f/pubsub-plus-connector/src/main/java/io/quarkiverse/solace/fault/SolaceErrorTopicPublisherHandler.java#L33

We can remove the errorTopic field completely.

@SravanThotakura05 SravanThotakura05 self-assigned this Dec 20, 2023
@ozangunalp
Copy link
Collaborator Author

@SravanThotakura05 Here we can simply log the exception on the result Uni :

        return Uni.createFrom().<PublishReceipt>emitter(e -> {
            try {
                // always wait for error message publish receipt to ensure it is successfully spooled on broker.
                publisher.publish(outboundMessage, Topic.of(errorTopic), e);
            } catch (Throwable t) {
                e.fail(t);
            }
        }).onFailure().invoke(t -> SolaceLogging.log.publishException(errorTopic, t));

SravanThotakura05 added a commit that referenced this issue Jan 1, 2024
@SravanThotakura05 SravanThotakura05 mentioned this issue Jan 1, 2024
@SravanThotakura05 SravanThotakura05 linked a pull request Jan 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants