Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NoteBlockAPI 2.0 #27

Open
mibby opened this issue Dec 29, 2022 · 0 comments
Open

Update to NoteBlockAPI 2.0 #27

mibby opened this issue Dec 29, 2022 · 0 comments

Comments

@mibby
Copy link

mibby commented Dec 29, 2022

Would it be possible to update to NoteBlockAPI 2.0 officially? I have a fork based on the latest upstream commit 13f36da and this PR #19 with @jhooc77 NBAPI 2.0 fix commit in this branch jhooc77@73d89aa.

This can be found here.
https://github.com/mibby/MusicBox

Upon comparison testing between both NoteBlockAPI versions, 2.0 seems to significantly improve playback performance and sound. Playback is no longer choppy or randomly cutting out since it is async and the timing / audible octave range sounds much better, even with terrible NBS converted midi files. Especially if you use extendedOctavesRange and a resource pack that supports the 10 octave range. Oddly enough even if you use the octave range patch with 1.x NBAPI, lows still sound better on 2.0.

I did however notice three issues currently with the 2.0 changes;

  1. Song doesn't properly destroy itself on end anymore. The BossBar display remains up and duration bar filled. You have to click the Stop button to remove it.

Believe to be caused by this change and isn't fixed in MusicBox fully. destroyed -> !playing isn't enough of a fix.
koca2000/NoteBlockAPI@a3b29f8

  1. The Song panel does not update to the current song in the center if you are playing a folder and it rolls into the next song. It only seems to update when you skip to the next song from the GUI.

  2. Stereo mode isn't being used anywhere. Playback is still mono in private listening and speaker mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant