Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve manifest TOML parsing diagnostics #34

Open
SpontanCombust opened this issue May 22, 2024 · 0 comments
Open

[FEATURE] Improve manifest TOML parsing diagnostics #34

SpontanCombust opened this issue May 22, 2024 · 0 comments
Labels
feature New feature or request

Comments

@SpontanCombust
Copy link
Owner

Some diagnostics generated by the LSP when parsing manifest files are not useful to the user.
For example, specifying a dependency like this:

content0 = { paths = "../content0" } #mind the typo "paths" instead of "path"

Will produce an error like this:

TOML file parsing error: TOML parse error at line 11, column 8
   |
11 | content0 = { paths = "../content0" }
   |            ^^^^^^^^^^^^^^^^^^^^^^^^^
data did not match any variant of untagged enum DependencyValue

It is safe to say that use would have no idea what to do about this "untagged enum DependencyValue".

The error should rather say something along the lines of

"path" key not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

No branches or pull requests

1 participant