Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI issues from #193 #194

Open
mtwente opened this issue Dec 8, 2024 · 0 comments
Open

GUI issues from #193 #194

mtwente opened this issue Dec 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mtwente
Copy link
Member

mtwente commented Dec 8, 2024

Current Behavior

I just noticed a few GUI issues on the browse page that were accidentally (re-)introduced by #193.
If I come across more stuff I'll add it to this issue.

  • line 116, search box

filterButton.focus(); (which was the CB standard setting) should be changed back to filterTextBox.focus()

  • line 106, items number
    In the current setup, translations were lost. Change back to language-independent
document.querySelector("#numberOf").innerHTML = `${filteredItems.length} / {{ items | size }}`;
  • line 79, View Full Record button
    In the current setup, English text is hardcoded and the button colour changed. Change back to outline-primary button and use translation variables as before:
    card += `<hr><a href="${itemHref}" class="btn btn-sm btn-outline-primary" title="link to ${obj.title}">` +
            `{{ site.data.translations['_includes']['js']['browse-js.html']['view-full-record'][site.lang] | default: 'View Full Record' }}</a>`;
  • additionally: remove the navigation buttons left/right on the compound object pages.

Steps To Reproduce

No response

Anything else?

No response

@mtwente mtwente added the bug Something isn't working label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant