Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow whitelisted cpu flags by default #940

Open
bchurchill opened this issue Nov 9, 2016 · 2 comments
Open

Only allow whitelisted cpu flags by default #940

bchurchill opened this issue Nov 9, 2016 · 2 comments
Assignees
Labels

Comments

@bchurchill
Copy link
Member

We should only ever use a cpu flag if we have tested it and know it works properly. New architectures add new flags, and bringing them in by default is problematic. I believe this is the root cause for #929 and #840. I think for now we should just keep these:

avx avx2
sse sse2 ssse3 sse4_1 sse4_2
fma cmov popcnt
bmi1 bmi2

Opinions? This should be nearly a one-liner.

@bchurchill bchurchill added the bug label Nov 9, 2016
@stefanheule
Copy link
Member

Are you proposing to change the default cpu flags to only the list we have tested? If so, sounds good to me.

@bchurchill
Copy link
Member Author

Yup. Ok, I'll do this when I get the chance.

@bchurchill bchurchill self-assigned this Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants