Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stoke bounded validator sometimes performs 0 SMT queries without telling the user #976

Open
stefanheule opened this issue Oct 3, 2017 · 3 comments
Assignees

Comments

@stefanheule
Copy link
Member

Stoke should print a warning if no comparisons are performed in the bounded validator, or have it print statistics on the number of paths found in the target/rewrite.

@bchurchill bchurchill self-assigned this Oct 3, 2017
@bchurchill
Copy link
Member

Actually, I'm realizing I was wrong about this. Your benchmark does have a path even with bound 1 that goes all the way through, it's just that it's not a feasible path. The SMT solver is making queries, but they're returning UNSAT because it's not possible for the paths to actually be executed.

All this to say: I've implemented this check in a branch (issue-976) but it doesn't actually give the warning on your benchmark. It does, however, warn that --bound 0 does nothing, so that seems worthwhile. Should we merge this?

bchurchill added a commit that referenced this issue Oct 3, 2017
@bchurchill
Copy link
Member

A more meaningful thing we could do is make extra queries to the SMT solver to check if the paths are feasible. We would then users if no feasible pairs of paths were tested. This would be easy to implement too. But, we would double the number of SMT queries in the worst case. Maybe this would be suitable for a debugging option.

@stefanheule
Copy link
Member Author

Yeah, having it as an option seems useful, and I would even argue having it on by default might be useful, too. It would in general be great if we could output some statistics to let the user know what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants