Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multistage builds #29

Open
radeno opened this issue Jun 11, 2018 · 4 comments
Open

Use multistage builds #29

radeno opened this issue Jun 11, 2018 · 4 comments

Comments

@radeno
Copy link
Collaborator

radeno commented Jun 11, 2018

It should be easier to maintain and faster to build and deploy new images when we use multistage docker builds.

Any ideas what files we need to copy from official node image?

from /usr/local/bin:

  • node
  • npm -> ../lib/node_modules/npm/bin/npm-cli.js
  • npx -> ../lib/node_modules/npm/bin/npx-cli.js
  • yarn -> /opt/yarn/bin/yarn
  • yarnpkg -> /opt/yarn/bin/yarn

from /usr/local/lib:

  • node_modules

from /opt:

  • yarn

Am i missing something?
Anyone with better linux experience. Are there any issues with copied binaries?
Any potential performance degradation ?

@radeno
Copy link
Collaborator Author

radeno commented Jun 14, 2018

I made first commit for combination 2-10 https://github.com/radeno/docker-ruby-node/tree/multistage/2-10 and build Docker images https://hub.docker.com/r/smikino/ruby-node/tags/

Size is identical (node manual is not copied), but build time is just couple of minutes on Docker Hub.

There are some issues because Docker COPY command can't copy symbolick links. So they must be created but RUN command.

@Starefossen
Copy link
Owner

I think this is the way to go forward. Would you be interested in creating a PR for this repository @radeno?

@radeno
Copy link
Collaborator Author

radeno commented Aug 3, 2018

@Starefossen i could make PR. no problem for me. But need deeper testing

@radeno
Copy link
Collaborator Author

radeno commented Aug 17, 2018

#32 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants