-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multistage builds #29
Comments
I made first commit for combination 2-10 https://github.com/radeno/docker-ruby-node/tree/multistage/2-10 and build Docker images https://hub.docker.com/r/smikino/ruby-node/tags/ Size is identical (node manual is not copied), but build time is just couple of minutes on Docker Hub. There are some issues because Docker COPY command can't copy symbolick links. So they must be created but RUN command. |
I think this is the way to go forward. Would you be interested in creating a PR for this repository @radeno? |
@Starefossen i could make PR. no problem for me. But need deeper testing |
#32 PR |
It should be easier to maintain and faster to build and deploy new images when we use multistage docker builds.
Any ideas what files we need to copy from official node image?
from /usr/local/bin:
from /usr/local/lib:
from /opt:
Am i missing something?
Anyone with better linux experience. Are there any issues with copied binaries?
Any potential performance degradation ?
The text was updated successfully, but these errors were encountered: