Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Replay Refactor Outage #334

Open
3 tasks
kelvinkoon opened this issue Nov 6, 2023 · 2 comments
Open
3 tasks

Investigate Replay Refactor Outage #334

kelvinkoon opened this issue Nov 6, 2023 · 2 comments
Labels
ps ingestion order up tests like eating vegetables

Comments

@kelvinkoon
Copy link
Collaborator

Describe the issue
The PS replay site has been refactored as per: https://twitter.com/PokemonShowdown/status/1721051985720565853
Replay retrieval is broken on the data pipeline. This is a result of HTML parsing being changed.

The solution is as follows:

Acceptance Criteria

  • Fix replay parsing
  • Fix unit tests
  • Deploy to prod
@kelvinkoon kelvinkoon added ps ingestion order up tests like eating vegetables labels Nov 6, 2023
@Zarel
Copy link

Zarel commented Nov 6, 2023

Were you using HTML scraping before? Our documented API for replay searches is here:

https://github.com/smogon/pokemon-showdown-client/blob/master/WEB-API.md#replay-search

@kelvinkoon
Copy link
Collaborator Author

Were you using HTML scraping before? Our documented API for replay searches is here:

https://github.com/smogon/pokemon-showdown-client/blob/master/WEB-API.md#replay-search

Thanks for the response!
It was confirmed the API wasn't ported last night which caused some issues on our end. https://x.com/notcelsiusdeg/status/1721387903194964426?s=46

We'll keep monitoring for any issues in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ps ingestion order up tests like eating vegetables
Projects
None yet
Development

No branches or pull requests

2 participants