Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaesen dice roll commands not displaying proper die images #220

Open
1 task done
Caramel-Raccoon opened this issue Sep 25, 2024 · 6 comments
Open
1 task done

Vaesen dice roll commands not displaying proper die images #220

Caramel-Raccoon opened this issue Sep 25, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Caramel-Raccoon
Copy link

Which command was used?

/roll vaesen

Issue Description

When executing a /roll vaesen command, the die results under "Details" show the results of your roll. However, the emojis displayed at the top of the app's response displays only :vaesenb0: emojis for all dice results, except for successes, where it then properly displays the :vaesenb6: emoji.

Steps to reproduce:

  1. Perform any /roll vaesen command
  2. Hope you don't roll all 6's
  3. Observe
    image_2024-09-24_223559796
    image_2024-09-24_223623460

Priority this issue should have?

Low (formatting issues, things that don't impact operation)

Bot's Permissions

  • I confirm that I checked the bot's permissions
@Caramel-Raccoon Caramel-Raccoon added the bug Something isn't working label Sep 25, 2024
@Stefouch
Copy link
Owner

It's because I only have two emoji faces for this die: vaesenb6 (success) and vaesenb0 (blank - any other face)

@Caramel-Raccoon
Copy link
Author

Oh? Is it an issue with implementing image files for the emoji faces, or do you just not have them for some reason? And if that's the case, would you consider implementing them if I got someone to make them and they were of appropriate quality?

@Stefouch
Copy link
Owner

Stefouch commented Sep 25, 2024

It was an issue related to emoji slots being limited to servers. Each supported game requires 6-12-24-40 extra emoji for each dice faces, sometimes way more with step dice, but a server could hold only 50 emojis for free. So the compromise was to use less emojis per dice.

BUT.. now bots can accept up to 2000 slots. So new dice face emoji could be added easily. If you know someone who can draw them, I have all resources available here - in the "vaesen" folder. Format must be PNG/JPG/GIF 128x128, max 256 kB of size.

@Caramel-Raccoon
Copy link
Author

Alright, I'll definitely see if I can get that stuff to you sometime soon.

@Caramel-Raccoon
Copy link
Author

Caramel-Raccoon commented Sep 25, 2024

Alright so I just said screw it and did it myself lmfao. Lemme know if there's anything wrong with these files and I'll make adjustments.
vaesen-b1
vaesen-b2
vaesen-b3
vaesen-b4
vaesen-b5

Also, lemme know if this isn't how you want me to submit them to you, and if you'd rather me drop them in a Google Drive or something.

@Caramel-Raccoon
Copy link
Author

It was an issue related to emoji slots being limited to servers. Each supported game requires 6-12-24-40 extra emoji for each dice faces, sometimes way more with step dice, but a server could hold only 50 emojis for free. So the compromise was to use less emojis per dice.

BUT.. now bots can accept up to 2000 slots. So new dice face emoji could be added easily. If you know someone who can draw them, I have all resources available here - in the "vaesen" folder. Format must be PNG/JPG/GIF 128x128, max 256 kB of size.

Just bumping to see if this has been checked recently, and to double check to see if the image files are good or if they need changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants