Damage Transaction does not fail if 0 damage is dealt

[adapap]

In the case where zero damage is dealt, such as in the case of an immunity, the test does not fail if you pass in a non-zero expected value for damage.

[dyc3]

You're referring to the HaveTransaction matcher right? That was intentional, because it would allow us to test things like turn order without necessarily relying on the damage dealt. In hindsight, probably a bad idea.

[adapap]

We could alternatively make immunities cause a MoveFailTransaction, but having a nice way to check turn order would be nice (necessary in #198/lagging tail for example).

[dyc3]

I think we should make some test helpers specifically for damage transactions, or have the HaveTransaction matcher take another argument to make it ignore fields on the transaction by name.

[adapap]

Is this closed now @dyc3

[dyc3]

Not as far as I know

[adapap]

Update: I think this also applies for nil moves? e.g. weather not having an associated move attached but dealing some damage