Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fixes in parse_xml_v4_file.py #9

Open
sjsf00 opened this issue Sep 29, 2024 · 0 comments
Open

Potential fixes in parse_xml_v4_file.py #9

sjsf00 opened this issue Sep 29, 2024 · 0 comments

Comments

@sjsf00
Copy link

sjsf00 commented Sep 29, 2024

In the original file from 2005 to 2012, the information of inventors tree is like:

<applicants>
<applicant sequence="001" app-type="applicant-inventor" designation="us-only">
<addressbook>
<last-name>Davis</last-name>
<first-name>Shawn P.</first-name>
<address>
<city>Jefferson Hills</city>
<state>PA</state>
<country>US</country>
</address>
</addressbook>
<nationality>
<country>omitted</country>
</nationality>
<residence>
<country>US</country>
</residence>
</applicant>
<applicant sequence="002" app-type="applicant-inventor" designation="us-only">
<addressbook>
<last-name>Garbin</last-name>
<first-name>Kelly</first-name>
<address>
<city>St. Louis</city>
<state>MO</state>
<country>US</country>
</address>
</addressbook>
<nationality>
<country>omitted</country>
</nationality>
<residence>
<country>US</country>
</residence>
</applicant>
<applicant sequence="003" app-type="applicant-inventor" designation="us-only">
<addressbook>
<last-name>Russell</last-name>
<first-name>Wellington Kelvin</first-name>
<address>
<city>Houston</city>
<state>TX</state>
<country>US</country>
</address>
</addressbook>
<nationality>
<country>omitted</country>
</nationality>
<residence>
<country>US</country>
</residence>
</applicant>
</applicants>

I think the branch should be like: ~/applicants/applicant or ~/applicants to parse multiple inventor info

But in parse_xml_v4_file.py, both old and new branch are wrote like:

line49: us_parties_inventors_path = f'{us_parties_base_path}/inventors/inventor'
line52: us_parties_inventors_path_old = f'{us_parties_base_path_old}/inventors/inventor'

Using the code to parse data from 2005 to 2012 with data_items:['INVT'], it supposed to return the inventors info, but it returns None.

Furthermore, I am not pretty sure if the parser parsing correctly when there are multiple inventors, I think it may needs to be f'{us_parties_base_path}/inventors' for that type of case(mostly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant