Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to add potion recipes to guide #65

Closed
Lothrazar opened this issue Apr 28, 2017 · 11 comments
Closed

Is there a way to add potion recipes to guide #65

Lothrazar opened this issue Apr 28, 2017 · 11 comments

Comments

@Lothrazar
Copy link
Contributor

Potions use IBrewingRecipe , which does not extend IRecipe. So the crafting recipe page wont work

I looked through the documentation and source code, and it seems like we have PageIRecipe, PageFurnaceRecipe, and a few pages for sounds and text and images, but no text for potions.

@TehNut
Copy link
Member

TehNut commented Apr 28, 2017

Just create a new page type. You're not limited to what we provide.

@TehNut TehNut closed this as completed Apr 28, 2017
@Lothrazar
Copy link
Contributor Author

Oh that makes sense. Thanks

@Lothrazar
Copy link
Contributor Author

Would you consider accepting a pull request with a PageBrewingRecipe into the base GuideAPI mod?

I havent made one yet.. but existing pages have nice clean readable code so ill probably be making one for my own use anyway.

Anyway let me know if you accept submissions like that @TehNut

@TehNut
Copy link
Member

TehNut commented Apr 29, 2017

If it supports a vanilla system, I'll gladly take new default page types.

@Lothrazar
Copy link
Contributor Author

Opinions of my texture // where to put output icon? Got this so far
potion

Havent cloned repo yet just working in my own codebase. Ill try to get pr by sunday

@ChloeDawn
Copy link
Contributor

I'd recommend a more compact layout, similar to JEI's.. something like this

@ChloeDawn
Copy link
Contributor

ChloeDawn commented Apr 29, 2017

Hopefully once #60 gets resolved, you'll be able to directly render the potion recipe from JEI when's its present, allowing your guide books to support modified recipes via CraftTweaker scripts etc

@TehNut
Copy link
Member

TehNut commented Apr 29, 2017

Currently asking Kit to redo all the existing page stuff like what she posted

@ChloeDawn
Copy link
Contributor

Re-texture PR incoming (ノ◕ヮ◕)ノ*:・゚✧

@Lothrazar
Copy link
Contributor Author

Wow so pretty! Cool ill wait until textures are in so i wont worry about that and stay in the code.

@Lothrazar
Copy link
Contributor Author

forked and pulled code in from my own repository. This is what i have so far. Without textures and subject to change. #66

Let me know if anything needs to change with this. I couldnt get it running with the standalone repo, so technically untested but i had started out just in my own repo where i had it working https://github.com/PrinceOfAmber/Cyclic/blob/249946a1669a0fded529357a141fbf2385c19b9d/src/main/java/com/lothrazar/cyclicmagic/PageBrewingRecipe.java

If you need anything and im not responding right away ping me on twitter, otherwise i will check back in periodically https://twitter.com/lothrazar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants